Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] wallet: Check if maintenance changes the balance #7229

Merged

Conversation

@MarcoFalke
Copy link
Member

MarcoFalke commented Dec 18, 2015

Takes about 13 seconds on my system so one could argue to put this into extended.

MarcoFalke added 2 commits Dec 15, 2015
* Remove outdated comment
* Remove unneeded 0s
* Remove semicolons
@MarcoFalke
Copy link
Member Author

MarcoFalke commented Dec 18, 2015

Looks like there is a bug with lock order: #7231

@laanwj
Copy link
Member

laanwj commented Jan 7, 2016

utACK

@laanwj laanwj merged commit fa33d97 into bitcoin:master Jan 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jan 7, 2016
fa33d97 [walletdb] Add missing LOCK() in Recover() for dummyWallet (MarcoFalke)
fa14d99 [qa] check if wallet or blochchain maintenance changes the balance (MarcoFalke)
fa0765d [qa] Cleanup wallet.py test (MarcoFalke)
laanwj added a commit that referenced this pull request Jan 7, 2016
- [qa] Cleanup wallet.py test
- [qa] check if wallet or blochchain maintenance changes the balance
- [walletdb] Add missing LOCK() in Recover() for dummyWallet

Github-Pull: #7229
Rebased-From: fa0765d fa14d99 fa33d97
@MarcoFalke MarcoFalke deleted the MarcoFalke:MarcoFalke-2015-rpcWalletMaintenance branch Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.