New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some instances of formatWithUnit with formatHtmlWithUnit #7255

Merged
merged 2 commits into from Jan 4, 2016

Conversation

Projects
None yet
5 participants
@fanquake
Member

fanquake commented Dec 26, 2015

Strings in a HTML context should be using formatHtmlWithUnit.

Replace some instances of formatWithUnit with formatHtmlWithUnit
Strings in a HTML context should be using formatHtmlWithUnit.

@jonasschnelli jonasschnelli added the GUI label Dec 27, 2015

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Dec 29, 2015

Contributor

light utACK

Contributor

dcousens commented Dec 29, 2015

light utACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jan 3, 2016

Contributor

utACK

Contributor

paveljanik commented Jan 3, 2016

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Jan 4, 2016

ACK 6fd0a07

@jonasschnelli jonasschnelli merged commit 6fd0a07 into bitcoin:master Jan 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jan 4, 2016

Merge pull request #7255
6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

Replace some instances of formatWithUnit with formatHtmlWithUnit
Strings in a HTML context should be using formatHtmlWithUnit.

Github-Pull: #7255
Rebased-From: 5fdf32d

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

Replace some instances of formatWithUnit with formatHtmlWithUnit
Strings in a HTML context should be using formatHtmlWithUnit.

Github-Pull: #7255
Rebased-From: 5fdf32d

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 10, 2016

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jan 13, 2016

Replace some instances of formatWithUnit with formatHtmlWithUnit
Strings in a HTML context should be using formatHtmlWithUnit.

Github-Pull: #7255
Rebased-From: 5fdf32d

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Feb 12, 2016

@fanquake fanquake deleted the fanquake:bitcoinunits-format branch May 12, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 5, 2017

Merge pull request #7255
6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 7, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 1 (#1614)
* Merge pull request #7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request #7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request #7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request #7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request #7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request #7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge #7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge #7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge #7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment