Skip to content

[init] Add missing help for args - #7290

Merged
laanwj merged 4 commits into
bitcoin:masterfrom
maflcko:Mf1601-doc
Jan 18, 2016
Merged

[init] Add missing help for args #7290
laanwj merged 4 commits into
bitcoin:masterfrom
maflcko:Mf1601-doc

Conversation

@maflcko

@maflcko maflcko commented Jan 4, 2016

Copy link
Copy Markdown
Member

No description provided.

@maflcko

maflcko commented Jan 4, 2016

Copy link
Copy Markdown
Member Author

This also includes a bugfix:

screenshot from 2016-01-04 18-53-38
screenshot from 2016-01-04 18-53-22

@jonasschnelli

jonasschnelli commented Jan 4, 2016

Copy link
Copy Markdown
Contributor

utACK.
Nice catch (missing uacomment and maptxfee)!

@fanquake

fanquake commented Jan 4, 2016

Copy link
Copy Markdown
Member

utACK

On Tuesday, 5 January 2016, Jonas Schnelli notifications@github.com wrote:

utACK.
Nice catch (missing uacomment and maptxfee)!

—
Reply to this email directly or view it on GitHub
#7290 (comment).

@laanwj

laanwj commented Jan 7, 2016

Copy link
Copy Markdown
Member

Needs rebase after #7257

@maflcko

maflcko commented Jan 7, 2016

Copy link
Copy Markdown
Member Author

Rebased.

paveljanik
paveljanik reviewed Jan 9, 2016
View reviewed changes
Comment thread src/init.cpp Outdated

@paveljanik paveljanik Jan 9, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As -mocktime=0 is a no op, I'd remove the default. What about this:

Replace actual time with <n> seconds since epoch

@maflcko maflcko Jan 9, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a developer documentation and I think it's useful to know that 0 means noop.

Though, I am using your extended description.

@paveljanik

paveljanik commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

But ACK anyway.

@maflcko

maflcko commented Jan 14, 2016

Copy link
Copy Markdown
Member Author

@laanwj Anything holding this back? (Some of this actually should go into 0.12.0, I can prepare the backport after you did the merge)

@jonasschnelli

jonasschnelli commented Jan 14, 2016

Copy link
Copy Markdown
Contributor

rc1 has be detached. I guess only important bugfixes should go into 0.12 now. But Re-ACK for master.

@laanwj
laanwj merged commit fa461df into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
@laanwj
Merge pull request #7290
c851d8d 
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
@maflcko
maflcko deleted the Mf1601-doc branch January 18, 2016 10:23
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 18, 2016
MarcoFalke
[init] Fix error message of maxtxfee invalid amount
44438a1 
Github-Pull: bitcoin#7290
Rebased-From: fac11ea
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 18, 2016
MarcoFalke
[init] Add missing help for args
236686b 
Github-Pull: bitcoin#7290
Rebased-From: fa6ab96 faa572a fa461df
codablock referenced this pull request in codablock/dash Dec 9, 2017
@laanwj @codablock
Merge pull request dashpay#7290
723eacf 
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maflcko @jonasschnelli @fanquake @laanwj @paveljanik