New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[init] Add missing help for args #7290

Merged
merged 4 commits into from Jan 18, 2016

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Jan 4, 2016

No description provided.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 4, 2016

Member

This also includes a bugfix:

screenshot from 2016-01-04 18-53-38
screenshot from 2016-01-04 18-53-22

Member

MarcoFalke commented Jan 4, 2016

This also includes a bugfix:

screenshot from 2016-01-04 18-53-38
screenshot from 2016-01-04 18-53-22

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 4, 2016

Member

utACK.
Nice catch (missing uacomment and maptxfee)!

Member

jonasschnelli commented Jan 4, 2016

utACK.
Nice catch (missing uacomment and maptxfee)!

@jonasschnelli jonasschnelli added the Docs label Jan 4, 2016

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jan 4, 2016

Member

utACK

On Tuesday, 5 January 2016, Jonas Schnelli notifications@github.com wrote:

utACK.
Nice catch (missing uacomment and maptxfee)!


Reply to this email directly or view it on GitHub
#7290 (comment).

Member

fanquake commented Jan 4, 2016

utACK

On Tuesday, 5 January 2016, Jonas Schnelli notifications@github.com wrote:

utACK.
Nice catch (missing uacomment and maptxfee)!


Reply to this email directly or view it on GitHub
#7290 (comment).

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 7, 2016

Member

Needs rebase after #7257

Member

laanwj commented Jan 7, 2016

Needs rebase after #7257

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 7, 2016

Member

Rebased.

Member

MarcoFalke commented Jan 7, 2016

Rebased.

Show outdated Hide outdated src/init.cpp
@@ -453,6 +459,7 @@ std::string HelpMessage(HelpMessageMode mode)
if (showDebug)
{
strUsage += HelpMessageOpt("-logtimemicros", strprintf("Add microsecond precision to debug timestamps (default: %u)", DEFAULT_LOGTIMEMICROS));
strUsage += HelpMessageOpt("-mocktime=<n>", "Replace actual time with <n> (default: 0)");

This comment has been minimized.

@paveljanik

paveljanik Jan 9, 2016

Contributor

As -mocktime=0 is a no op, I'd remove the default. What about this:

Replace actual time with <n> seconds since epoch
@paveljanik

paveljanik Jan 9, 2016

Contributor

As -mocktime=0 is a no op, I'd remove the default. What about this:

Replace actual time with <n> seconds since epoch

This comment has been minimized.

@MarcoFalke

MarcoFalke Jan 9, 2016

Member

It's a developer documentation and I think it's useful to know that 0 means noop.

Though, I am using your extended description.

@MarcoFalke

MarcoFalke Jan 9, 2016

Member

It's a developer documentation and I think it's useful to know that 0 means noop.

Though, I am using your extended description.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jan 9, 2016

Contributor

But ACK anyway.

Contributor

paveljanik commented Jan 9, 2016

But ACK anyway.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 14, 2016

Member

@laanwj Anything holding this back? (Some of this actually should go into 0.12.0, I can prepare the backport after you did the merge)

Member

MarcoFalke commented Jan 14, 2016

@laanwj Anything holding this back? (Some of this actually should go into 0.12.0, I can prepare the backport after you did the merge)

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 14, 2016

Member

rc1 has be detached. I guess only important bugfixes should go into 0.12 now. But Re-ACK for master.

Member

jonasschnelli commented Jan 14, 2016

rc1 has be detached. I guess only important bugfixes should go into 0.12 now. But Re-ACK for master.

@laanwj laanwj merged commit fa461df into bitcoin:master Jan 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 18, 2016

Merge pull request #7290
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1601-doc branch Jan 18, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 18, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 18, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge pull request #7290
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge pull request #7290
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request #7290
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request #7290
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment