Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[init] Add missing help for args #7290

Merged
merged 4 commits into from Jan 18, 2016
Merged

Conversation

MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 4, 2016

No description provided.

@MarcoFalke
Copy link
Member Author

MarcoFalke commented Jan 4, 2016

This also includes a bugfix:

screenshot from 2016-01-04 18-53-38
screenshot from 2016-01-04 18-53-22

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 4, 2016

utACK.
Nice catch (missing uacomment and maptxfee)!

@fanquake
Copy link
Member

fanquake commented Jan 4, 2016

utACK

On Tuesday, 5 January 2016, Jonas Schnelli notifications@github.com wrote:

utACK.
Nice catch (missing uacomment and maptxfee)!


Reply to this email directly or view it on GitHub
#7290 (comment).

@laanwj
Copy link
Member

laanwj commented Jan 7, 2016

Needs rebase after #7257

@MarcoFalke
Copy link
Member Author

MarcoFalke commented Jan 7, 2016

Rebased.

@@ -453,6 +459,7 @@ std::string HelpMessage(HelpMessageMode mode)
if (showDebug)
{
strUsage += HelpMessageOpt("-logtimemicros", strprintf("Add microsecond precision to debug timestamps (default: %u)", DEFAULT_LOGTIMEMICROS));
strUsage += HelpMessageOpt("-mocktime=<n>", "Replace actual time with <n> (default: 0)");
Copy link
Contributor

@paveljanik paveljanik Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As -mocktime=0 is a no op, I'd remove the default. What about this:

Replace actual time with <n> seconds since epoch

Copy link
Member Author

@MarcoFalke MarcoFalke Jan 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a developer documentation and I think it's useful to know that 0 means noop.

Though, I am using your extended description.

@paveljanik
Copy link
Contributor

paveljanik commented Jan 9, 2016

But ACK anyway.

@MarcoFalke
Copy link
Member Author

MarcoFalke commented Jan 14, 2016

@laanwj Anything holding this back? (Some of this actually should go into 0.12.0, I can prepare the backport after you did the merge)

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 14, 2016

rc1 has be detached. I guess only important bugfixes should go into 0.12 now. But Re-ACK for master.

@laanwj laanwj merged commit fa461df into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
@MarcoFalke MarcoFalke deleted the Mf1601-doc branch Jan 18, 2016
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Jan 18, 2016
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Jan 18, 2016
codablock pushed a commit to codablock/dash that referenced this pull request Dec 9, 2017
fa461df Clarify mocktime help message (MarcoFalke)
faa572a [init] Help Msg: Use Params(CBaseChainParams::MAIN) (MarcoFalke)
fa6ab96 [init] Add missing help for args (MarcoFalke)
fac11ea [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants