Skip to content

[Tests] Eliminate intermittent failures in sendheaders.py#7308

Merged
laanwj merged 2 commits into
bitcoin:masterfrom
sdaftuar:fix-sendheaders
Jan 9, 2016
Merged

[Tests] Eliminate intermittent failures in sendheaders.py#7308
laanwj merged 2 commits into
bitcoin:masterfrom
sdaftuar:fix-sendheaders

Conversation

@sdaftuar

@sdaftuar sdaftuar commented Jan 7, 2016

Copy link
Copy Markdown
Member

Fixes #7246

First commit adds a helper I found useful to conclusively debugging this particular issue, but I can drop the commit if we don't want this for some reason.

The second commit addresses the race condition in sendheaders.py.

@jgarzik

jgarzik commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

ut ACK

@laanwj

laanwj commented Jan 9, 2016

Copy link
Copy Markdown
Member

utACK, thanks!

@laanwj
laanwj merged commit 168915e into bitcoin:master Jan 9, 2016
laanwj added a commit that referenced this pull request Jan 9, 2016
168915e Eliminate race condition in sendheaders.py test (Suhas Daftuar)
82a0ce0 Add race-condition debugging tool to mininode (Suhas Daftuar)
laanwj pushed a commit that referenced this pull request Jan 9, 2016
- Add race-condition debugging tool to mininode
- Eliminate race condition in sendheaders.py test

Clear the last block announcement before mining new blocks.

Github-Pull: #7308
Rebased-From: 82a0ce0 168915e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent test failures in sendheaders.py

4 participants