Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Eliminate intermittent failures in sendheaders.py #7308

Merged
merged 2 commits into from Jan 9, 2016

Conversation

sdaftuar
Copy link
Member

@sdaftuar sdaftuar commented Jan 7, 2016

Fixes #7246

First commit adds a helper I found useful to conclusively debugging this particular issue, but I can drop the commit if we don't want this for some reason.

The second commit addresses the race condition in sendheaders.py.

@jgarzik
Copy link
Contributor

jgarzik commented Jan 7, 2016

ut ACK

@laanwj
Copy link
Member

laanwj commented Jan 9, 2016

utACK, thanks!

@laanwj laanwj merged commit 168915e into bitcoin:master Jan 9, 2016
laanwj added a commit that referenced this pull request Jan 9, 2016
168915e Eliminate race condition in sendheaders.py test (Suhas Daftuar)
82a0ce0 Add race-condition debugging tool to mininode (Suhas Daftuar)
laanwj pushed a commit that referenced this pull request Jan 9, 2016
- Add race-condition debugging tool to mininode
- Eliminate race condition in sendheaders.py test

Clear the last block announcement before mining new blocks.

Github-Pull: #7308
Rebased-From: 82a0ce0 168915e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent test failures in sendheaders.py
4 participants