[Tests] Eliminate intermittent failures in sendheaders.py #7308

Merged
merged 2 commits into from Jan 9, 2016

Conversation

Projects
None yet
4 participants
@sdaftuar
Member

sdaftuar commented Jan 7, 2016

Fixes #7246

First commit adds a helper I found useful to conclusively debugging this particular issue, but I can drop the commit if we don't want this for some reason.

The second commit addresses the race condition in sendheaders.py.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jan 7, 2016

Contributor

ut ACK

Contributor

jgarzik commented Jan 7, 2016

ut ACK

@jonasschnelli jonasschnelli added the Tests label Jan 8, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 9, 2016

Member

utACK, thanks!

Member

laanwj commented Jan 9, 2016

utACK, thanks!

@laanwj laanwj merged commit 168915e into bitcoin:master Jan 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 9, 2016

Merge pull request #7308
168915e Eliminate race condition in sendheaders.py test (Suhas Daftuar)
82a0ce0 Add race-condition debugging tool to mininode (Suhas Daftuar)

laanwj added a commit that referenced this pull request Jan 9, 2016

[Tests] Eliminate intermittent failures in sendheaders.py
- Add race-condition debugging tool to mininode
- Eliminate race condition in sendheaders.py test

Clear the last block announcement before mining new blocks.

Github-Pull: #7308
Rebased-From: 82a0ce0 168915e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment