/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[trivial] fixing multiple typos #7313

Merged
merged 1 commit into from Jan 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@calebogden @paveljanik @dcousens @fanquake @jonasschnelli @MarcoFalke @laanwj
@calebogden
Contributor

calebogden commented Jan 8, 2016

No description provided.

@calebogden calebogden changed the title from Found and fixed some typos to [trivial] fixing multiple typos Jan 8, 2016

@paveljanik
Contributor

paveljanik commented Jan 8, 2016

ACK after squashing into one commit.
@dcousens
Contributor

dcousens commented Jan 8, 2016

trivial ACK @ f85d3d7, please squash
@fanquake
Member

fanquake commented Jan 8, 2016

Nack as is. If you are going to correct them please fix them all. From torcontrol.cpp

    connected is the handler that is called when connection is succesfully established.      [position 82:67]   
    LogPrint("tor", "tor: Succesfully connected!\n");      [position 180:31]    
    Callback after succesful connection      [position 383:24]  
    LogPrint("tor", "tor: ADD_ONION succesful\n");      [position 422:41]   
    LogPrint("tor", "tor: Authentication succesful\n");      [position 451:46]  
    LogPrint("tor", "tor: SAFECOOKIE authentication challenge succesful\n");      [position 504:67]
@jonasschnelli
Member

jonasschnelli commented Jan 8, 2016

agree with @fanquake: would be nice to fix all of them.
Once fixed, ACK after squashing.
@calebogden
Contributor

calebogden commented Jan 8, 2016

@fanquake @jonasschnelli Ah yeah I thought I grabbed those too, fixed!
@MarcoFalke
Member

MarcoFalke commented Jan 8, 2016

utACK 0331aa3
@dcousens
Contributor

dcousens commented Jan 9, 2016

utACK 0331aa3
@paveljanik
Contributor

paveljanik commented Jan 9, 2016

trivial ACK 0331aa3
@fanquake
Member

fanquake commented Jan 16, 2016

ACK 0331aa3

@laanwj laanwj merged commit 0331aa3 into bitcoin:master Jan 18, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 18, 2016

@laanwj
Merge pull request #7313 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
5e00147

@calebogden calebogden deleted the calebogden:patch-1 branch Jan 19, 2016

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Feb 12, 2016

@calebogden @luke-jr
Fixing typos on security-check.py and torcontrol.cpp 
Github-Pull: #7313
Rebased-From: 0331aa3
d68de7a

@str4d str4d referenced this pull request in zcash/zcash Mar 24, 2017

Merged

Tor ephemeral hidden services #2177

zkbot added a commit to zcash/zcash that referenced this pull request Mar 26, 2017

@zkbot
Auto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira 
Tor ephemeral hidden services

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6503 (included to reduce merge conflicts)
- bitcoin/bitcoin#6639
- bitcoin/bitcoin#6643
- bitcoin/bitcoin#7090
- bitcoin/bitcoin#7035
- bitcoin/bitcoin#7170
- bitcoin/bitcoin#7218 (non-QT part)
- bitcoin/bitcoin#7313
- bitcoin/bitcoin#7438
- bitcoin/bitcoin#7553
- bitcoin/bitcoin#7637
- bitcoin/bitcoin#7683
- bitcoin/bitcoin#7813
- bitcoin/bitcoin#7703
- bitcoin/bitcoin#8203
- bitcoin/bitcoin#9004
- bitcoin/bitcoin#9234
- bitcoin/bitcoin#9911 (partial)

Closes #2061.
45faa92

kyuupichan added a commit to kyuupichan/BitcoinUnlimited that referenced this pull request Apr 9, 2017

@laanwj @kyuupichan
Merge pull request #7313 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
57a1528

@kyuupichan kyuupichan referenced this pull request in BitcoinUnlimited/BitcoinUnlimited Apr 9, 2017

Merged

Net backports #435

kyuupichan added a commit to kyuupichan/BitcoinUnlimited that referenced this pull request Apr 29, 2017

@laanwj @kyuupichan
Merge pull request #7313 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
d46e0b1

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

@laanwj @codablock
Merge pull request #7313 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
8c51156

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

@laanwj @codablock
Merge pull request #7313 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
6ade556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment