New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Fix typo, wrong information in gettxout help text #7326

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
7 participants
@paveljanik
Contributor

paveljanik commented Jan 10, 2016

... reported to me by other user.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jan 10, 2016

utACK 3a9dfe9

@jmcorgan

This comment has been minimized.

Show comment
Hide comment
@jmcorgan

jmcorgan Jan 10, 2016

Contributor

utACK

Contributor

jmcorgan commented Jan 10, 2016

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Jan 11, 2016

ACK

@Xekyo

This comment has been minimized.

Show comment
Hide comment
@Xekyo

Xekyo Jan 11, 2016

Contributor

@paveljanik How about "vout index"?

Contributor

Xekyo commented Jan 11, 2016

@paveljanik How about "vout index"?

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Jan 11, 2016

Member

If we're changing it I think @Xekyo suggestion is best.

Member

instagibbs commented Jan 11, 2016

If we're changing it I think @Xekyo suggestion is best.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jan 11, 2016

Contributor

Sorry, but:

$ git grep "The output number" *
rpcrawtransaction.cpp:            "         \"vout\":n        (numeric, required) The output number\n"
rpcrawtransaction.cpp:            "       \"vout\": n,         (numeric) The output number\n"
rpcrawtransaction.cpp:            "         \"vout\":n,                  (numeric, required) The output number\n"
wallet/rpcwallet.cpp:            "         \"vout\": n         (numeric) The output number\n"
$ 
Contributor

paveljanik commented Jan 11, 2016

Sorry, but:

$ git grep "The output number" *
rpcrawtransaction.cpp:            "         \"vout\":n        (numeric, required) The output number\n"
rpcrawtransaction.cpp:            "       \"vout\": n,         (numeric) The output number\n"
rpcrawtransaction.cpp:            "         \"vout\":n,                  (numeric, required) The output number\n"
wallet/rpcwallet.cpp:            "         \"vout\": n         (numeric) The output number\n"
$ 
@Xekyo

This comment has been minimized.

Show comment
Hide comment
@Xekyo

Xekyo Jan 11, 2016

Contributor

@paveljanik: That may be so, but this number is more specifically the position within the transaction’s outputs. That’s why "index" would be more to the point. :)
If others agree, it could be updated in all the positions that you listed. If we’re not going to change it, I agree, though, that it should be consistent.

Contributor

Xekyo commented Jan 11, 2016

@paveljanik: That may be so, but this number is more specifically the position within the transaction’s outputs. That’s why "index" would be more to the point. :)
If others agree, it could be updated in all the positions that you listed. If we’re not going to change it, I agree, though, that it should be consistent.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jan 11, 2016

Contributor

@Xekyo It depends on your view. It can be index into vout array and the number of the vout in vouts. ;-)

I do not plan to change it in this PR.

Contributor

paveljanik commented Jan 11, 2016

@Xekyo It depends on your view. It can be index into vout array and the number of the vout in vouts. ;-)

I do not plan to change it in this PR.

@Xekyo

This comment has been minimized.

Show comment
Hide comment
@Xekyo

Xekyo Jan 11, 2016

Contributor

I feel that "vout number" is ambiguous: For a minute I thought you were telling me the line referred to "the number of outputs" as in how many there are.

But, since it refers to "an unspent transaction output" here, index would be an improvement because it is the correct technical term, making it easier to grasp and more precise. Anyway, your PR is an improvement to the previous state, so I ACK.

Contributor

Xekyo commented Jan 11, 2016

I feel that "vout number" is ambiguous: For a minute I thought you were telling me the line referred to "the number of outputs" as in how many there are.

But, since it refers to "an unspent transaction output" here, index would be an improvement because it is the correct technical term, making it easier to grasp and more precise. Anyway, your PR is an improvement to the previous state, so I ACK.

@laanwj laanwj merged commit 3a9dfe9 into bitcoin:master Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 13, 2016

Merge pull request #7326
3a9dfe9 Fix typo, wrong information in gettxout help text. (paveljanik)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Feb 12, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge pull request bitcoin#7326
3a9dfe9 Fix typo, wrong information in gettxout help text. (paveljanik)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge pull request bitcoin#7326
3a9dfe9 Fix typo, wrong information in gettxout help text. (paveljanik)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request bitcoin#7326
3a9dfe9 Fix typo, wrong information in gettxout help text. (paveljanik)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge pull request bitcoin#7326
3a9dfe9 Fix typo, wrong information in gettxout help text. (paveljanik)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment