[qt] Windows: Make rpcconsole monospace font larger#7364
[qt] Windows: Make rpcconsole monospace font larger#7364jonasschnelli merged 1 commit intobitcoin:masterfrom
Conversation
|
utACK for 0.12 (rc2) not sure if we want this for master/0.13 or if we should look for a better/alternative solution. Build to test should be ready soon: https://bitcoin.jonasschnelli.ch/pulls/7364/ |
|
Thanks for the binaries. Even though this is ugly, I'd say it should be merged into master as well. Lacking a better solution, it doesn't make things worse and backports easier. |
|
Why are we not using QFontInfo(fixedFontInfo).pointSize() here? |
|
Seems like QFont() has the same problems? Makes more sense to scale fixedFontInfo than to scale some other font's default size. Besides, we got that Qt5 thing since then? |
Previously we had a "default font", so that's the reference. Though, you are welcome to change that.
Doesn't change anything for Windows or Linux. Only a different font for OS X. |
|
Oh no, not more monospace related code changes. When are you guys going to give this up :-) |
|
Tested ACK fa6a59d. Current Master (to small on windows): Current 0.11 version, non pretty, non mono (people are use to this font size): |
fa6a59d [qt] Windows: Make rpcconsole monospace font larger (MarcoFalke)
|
I don't think this solution is acceptable in the longer term. We have to do one of these:
|



Probably fixes #7017.
Merges fine into
masterand0.12.