[walletdb] Fix syntax error in key parser

[maflcko]

This needs backport to all versions of bitcoin/altcoins after merge.

A dump may look like:

VERSION=3
format=bytevalue
database=main
type=btree
db_pagesize=4096
HEADER=END
<{Data}>
DATA=END

So the current parser gives us odd data like:

keyHex="DATA=END";
valueHex="";

(sometimes the other way round)

[laanwj]

Where does this value come from? If from berkeleydb itself: Is it documented, or available as some kind of constant?

[maflcko]

db_dump ~/.bitcoin/regtest/wallet.dat

https://docs.oracle.com/cd/E17275_01/html/api_reference/C/db_dump.html

http://web.deu.edu.tr/doc/berkeley/berkeleyDB/ref/dumpload/format.html

[dcousens]

We could probably make it a constant for our sakes anyway.

[laanwj]

Fixes #7379 I suppose?

[laanwj]

utACK

[maflcko]

Fixes #7379 I suppose?

There are other issues with salvagewallet, so I can't guarantee that.

[laanwj]

• Backported to 0.12 as 621bbd8
• Backported to 0.11 as c40ec14
• Backported to 0.10 as b0c97ce

[laanwj]

There are other issues with salvagewallet, so I can't guarantee that.

Right, I meant the specific problem. It's never possible to guarantee that you've solved all bugs. If only...

[jonasschnelli]

Nice catch!
Thanks for fixing.
Post merge ACK.