New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] rename "amount" to "requested amount" in receive coins table #7383

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Projects
None yet
4 participants
@jonasschnelli
Member

jonasschnelli commented Jan 20, 2016

Addresses #7014 (partial).

Users can be confused by looking at the "amount" column in the receive coins table (history or created addresses) because they expect the amount of "coins received by this address" instead of the "requested amount".

Renaming table header from "amount" to "requested amount".

@jonasschnelli jonasschnelli added the GUI label Jan 20, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 20, 2016

Member

utACK
(nit: please change the commit and pull request title to "requested amount" too)

Member

laanwj commented Jan 20, 2016

utACK
(nit: please change the commit and pull request title to "requested amount" too)

@jonasschnelli jonasschnelli changed the title from [Qt] rename "amount" to "received amount" in receive coins table to [Qt] rename "amount" to "requested amount" in receive coins table Jan 20, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 20, 2016

Member

Sorry. Typo. Fixed (reworded commit and PR title to "requested amount").

Member

jonasschnelli commented Jan 20, 2016

Sorry. Typo. Fixed (reworded commit and PR title to "requested amount").

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 20, 2016

Member

utACK 6693cb2

Member

MarcoFalke commented Jan 20, 2016

utACK 6693cb2

@MarcoFalke

View changes

Show outdated Hide outdated src/qt/recentrequeststablemodel.cpp
@@ -36,7 +36,7 @@ class ReceiveCoinsDialog : public QDialog
enum ColumnWidths {
DATE_COLUMN_WIDTH = 130,
LABEL_COLUMN_WIDTH = 120,
AMOUNT_MINIMUM_COLUMN_WIDTH = 160,
AMOUNT_MINIMUM_COLUMN_WIDTH = 180,

This comment has been minimized.

@MarcoFalke

MarcoFalke Jan 20, 2016

Member

Needs to be larger for me. (Or use the diff I provided below)

screenshot from 2016-01-20 16-50-46

@MarcoFalke

MarcoFalke Jan 20, 2016

Member

Needs to be larger for me. (Or use the diff I provided below)

screenshot from 2016-01-20 16-50-46

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jan 20, 2016

Member

utACK

Member

fanquake commented Jan 20, 2016

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 20, 2016

Member

Applied @MarcoFalke diff (force push). Thanks. It's a nice solution for a smaller column.

Member

jonasschnelli commented Jan 20, 2016

Applied @MarcoFalke diff (force push). Thanks. It's a nice solution for a smaller column.

@laanwj

View changes

Show outdated Hide outdated src/qt/recentrequeststablemodel.cpp
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 20, 2016

Why empty string?

You can keep the translation tr("Amount"); or just "Requested amount" without translation.

Why empty string?

You can keep the translation tr("Amount"); or just "Requested amount" without translation.

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 20, 2016

Owner

I guess the case where the option modal is not available only happens during GUI setup. IIRC no user will see this state.

Owner

jonasschnelli replied Jan 20, 2016

I guess the case where the option modal is not available only happens during GUI setup. IIRC no user will see this state.

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 20, 2016

Tested ACK df6e8e1 given that

no user will see this state

MarcoFalke replied Jan 20, 2016

Tested ACK df6e8e1 given that

no user will see this state

@jonasschnelli jonasschnelli merged commit df6e8e1 into bitcoin:master Jan 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jan 21, 2016

Merge #7383: [Qt] rename "amount" to "requested amount" in receive co…
…ins table

df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7383: [Qt] rename "amount" to "requested amount" in receive co…
…ins table

df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7383: [Qt] rename "amount" to "requested amount" in receive co…
…ins table

df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7383: [Qt] rename "amount" to "requested amount" in receive co…
…ins table

df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7383: [Qt] rename "amount" to "requested amount" in receive co…
…ins table

df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment