Skip to content

[qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH - #7384

Merged
jonasschnelli merged 1 commit into
bitcoin:masterfrom
maflcko:Mf1601-qtPeertableFix
Jan 23, 2016
Merged

jonasschnelli merged 1 commit into
bitcoin:masterfrom
maflcko:Mf1601-qtPeertableFix

Conversation

@maflcko

@maflcko maflcko commented Jan 20, 2016

Copy link
Copy Markdown
Member

Fixes #7362

@jonasschnelli

Copy link
Copy Markdown
Contributor

Tested ACK.

Before (Release 0.12.0rc1) with default window size:
bildschirmfoto 2016-01-21 um 11 28 26

This PR with default window size:
(resizing and right-scrolling the window will reveal the "ping time")
bildschirmfoto 2016-01-21 um 11 23 59

@laanwj

laanwj commented Jan 22, 2016

Copy link
Copy Markdown
Member

It looks like host/service has too much space by default?
Ah right this only shows IPv4, for IPv6 addresses it needs to be wider.
Concept ACK

@paveljanik

Copy link
Copy Markdown
Contributor

Tested ACK maflcko@faa9011

The same result here as @jonasschnelli.

@jonasschnelli
jonasschnelli merged commit faa9011 into bitcoin:master Jan 23, 2016
jonasschnelli added a commit that referenced this pull request Jan 23, 2016
faa9011 [qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH (MarcoFalke)
@maflcko
maflcko deleted the Mf1601-qtPeertableFix branch January 23, 2016 20:56
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 23, 2016
laanwj pushed a commit that referenced this pull request Feb 3, 2016
@laanwj laanwj mentioned this pull request Feb 3, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qt] Wrong column widths

4 participants