[qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH #7384

Merged
merged 1 commit into from Jan 23, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Jan 20, 2016

Fixes #7362

@jonasschnelli jonasschnelli added the GUI label Jan 21, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 21, 2016

Member

Tested ACK.

Before (Release 0.12.0rc1) with default window size:
bildschirmfoto 2016-01-21 um 11 28 26

This PR with default window size:
(resizing and right-scrolling the window will reveal the "ping time")
bildschirmfoto 2016-01-21 um 11 23 59

Member

jonasschnelli commented Jan 21, 2016

Tested ACK.

Before (Release 0.12.0rc1) with default window size:
bildschirmfoto 2016-01-21 um 11 28 26

This PR with default window size:
(resizing and right-scrolling the window will reveal the "ping time")
bildschirmfoto 2016-01-21 um 11 23 59

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 22, 2016

Member

It looks like host/service has too much space by default?
Ah right this only shows IPv4, for IPv6 addresses it needs to be wider.
Concept ACK

Member

laanwj commented Jan 22, 2016

It looks like host/service has too much space by default?
Ah right this only shows IPv4, for IPv6 addresses it needs to be wider.
Concept ACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jan 23, 2016

Contributor

Tested ACK MarcoFalke@faa9011

The same result here as @jonasschnelli.

Contributor

paveljanik commented Jan 23, 2016

Tested ACK MarcoFalke@faa9011

The same result here as @jonasschnelli.

@jonasschnelli jonasschnelli merged commit faa9011 into bitcoin:master Jan 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jan 23, 2016

Merge #7384: [qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH
faa9011 [qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1601-qtPeertableFix branch Jan 23, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 23, 2016

laanwj added a commit that referenced this pull request Feb 3, 2016

@laanwj laanwj referenced this pull request Feb 3, 2016

Closed

[0.12] Backports #7405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment