Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH #7384

Merged
merged 1 commit into from Jan 23, 2016

Conversation

MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 20, 2016

Fixes #7362

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 21, 2016

Tested ACK.

Before (Release 0.12.0rc1) with default window size:
bildschirmfoto 2016-01-21 um 11 28 26

This PR with default window size:
(resizing and right-scrolling the window will reveal the "ping time")
bildschirmfoto 2016-01-21 um 11 23 59

@laanwj
Copy link
Member

laanwj commented Jan 22, 2016

It looks like host/service has too much space by default?
Ah right this only shows IPv4, for IPv6 addresses it needs to be wider.
Concept ACK

@paveljanik
Copy link
Contributor

paveljanik commented Jan 23, 2016

Tested ACK MarcoFalke@faa9011

The same result here as @jonasschnelli.

@jonasschnelli jonasschnelli merged commit faa9011 into bitcoin:master Jan 23, 2016
jonasschnelli added a commit that referenced this pull request Jan 23, 2016
faa9011 [qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH (MarcoFalke)
@MarcoFalke MarcoFalke deleted the Mf1601-qtPeertableFix branch Jan 23, 2016
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Jan 23, 2016
laanwj pushed a commit that referenced this pull request Feb 3, 2016
@laanwj laanwj mentioned this pull request Feb 3, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qt] Wrong column widths
4 participants