Get rid of inaccurate ScriptSigArgsExpected #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK 5bfec00 |
|
@dcousens Some tests were failing, I updated the commit. |
|
utACK |
|
re-ACK 52b29dc |
|
ACK 52b29dc Constructed effectively the same patch on my own. |
laanwj
added a commit
that referenced
this pull request
Jan 22, 2016
52b29dc Get rid of inaccurate ScriptSigArgsExpected (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScriptSigArgsExpected was originally introduced to avoid a form of malleability (stuffing scriptSigs with superfluous arguments). This is no longer needed since the SCRIPT_VERIFY_CLEANSTACK and SCRIPT_VERIFY_SIGPUSHONLY cover all its use case more accurately and more efficiently.