New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] github-merge get toplevel dir without extra whitespace #7402

Merged
merged 1 commit into from Jan 25, 2016

Conversation

Projects
None yet
3 participants
@achow101
Member

achow101 commented Jan 23, 2016

Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 25, 2016

Member

utACK

Member

laanwj commented Jan 25, 2016

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 25, 2016

Member

Nit about commit message: please use the

Ttitle line
(empty line)
Description...

format. Otherwise everything ends up in the subject line, when viewing in git log short format (as used by #7395).

Member

laanwj commented Jan 25, 2016

Nit about commit message: please use the

Ttitle line
(empty line)
Description...

format. Otherwise everything ends up in the subject line, when viewing in git log short format (as used by #7395).

[devtools] github-merge get toplevel dir without extra whitespace
Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.
@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101

achow101 Jan 25, 2016

Member

@laanwj fixed that and force pushed

Member

achow101 commented Jan 25, 2016

@laanwj fixed that and force pushed

@laanwj laanwj merged commit 5ed2f16 into bitcoin:master Jan 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 25, 2016

Merge #7402: [devtools] github-merge get toplevel dir without extra w…
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)

@achow101 achow101 deleted the achow101:dev-tool-fix branch Jan 25, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7402: [devtools] github-merge get toplevel dir without extra w…
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7402: [devtools] github-merge get toplevel dir without extra w…
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7402: [devtools] github-merge get toplevel dir without extra w…
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7402: [devtools] github-merge get toplevel dir without extra w…
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment