New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example for listing ./configure flags #7428

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
3 participants
@nathaniel-mahieu
Contributor

nathaniel-mahieu commented Jan 27, 2016

Going through and building bitcoind is a great learning process. This is the only detail I found missing from the guide. I think this may be common knowledge but its key information for a new user needing to read the build guide.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 27, 2016

Member

I'd use "configure flags" not "compiler flags", to avoid confusion with CFLAGS/CXXFLAGS

Member

laanwj commented Jan 27, 2016

I'd use "configure flags" not "compiler flags", to avoid confusion with CFLAGS/CXXFLAGS

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jan 27, 2016

Member

./configure --help is somehow unrelated to compiling bitcoin. No strong opinion though.

Member

jonasschnelli commented Jan 27, 2016

./configure --help is somehow unrelated to compiling bitcoin. No strong opinion though.

@jonasschnelli jonasschnelli added the Docs label Jan 27, 2016

@nathaniel-mahieu nathaniel-mahieu changed the title from doc: add example for listing compiler flags to doc: add example for listing ./configure flags Jan 28, 2016

@laanwj

View changes

Show outdated Hide outdated doc/build-unix.md
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 29, 2016

Member

./configure --help is somehow unrelated to compiling bitcoin. No strong opinion though.

Some other configure options are explicitly listed in the build instructions. I don't think it hurts to tell that there may be other options available than those.

Member

laanwj commented Jan 29, 2016

./configure --help is somehow unrelated to compiling bitcoin. No strong opinion though.

Some other configure options are explicitly listed in the build instructions. I don't think it hurts to tell that there may be other options available than those.

@laanwj laanwj merged commit befeb55 into bitcoin:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 29, 2016

Merge #7428: doc: add example for listing ./configure flags
befeb55 Add example for displaying additional configure flags (Nathaniel Mahieu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment