Add whitelistforcerelay to control forced relaying. [#7099 redux] #7439

Merged
merged 2 commits into from Feb 1, 2016

Conversation

Projects
None yet
5 participants
@gmaxwell
Member

gmaxwell commented Jan 28, 2016

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
gets in the way of some useful reasons for whitelisting
peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
applications where a node is being used as a P2P connection
filter and multiplexer, but where you don't want it getting
in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.

Add whitelistforcerelay to control forced relaying.
Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
 gets in the way of some useful reasons for whitelisting
 peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
 applications where a node is being used as a P2P connection
 filter and multiplexer, but where you don't want it getting
 in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jan 29, 2016

Member

utACK 325c725

Member

laanwj commented Jan 29, 2016

utACK 325c725

@laanwj laanwj added this to the 0.12.0 milestone Jan 29, 2016

src/init.cpp
@@ -752,13 +753,19 @@ void InitParameterInteraction()
// disable walletbroadcast and whitelistalwaysrelay in blocksonly mode

This comment has been minimized.

@MarcoFalke

MarcoFalke Jan 29, 2016

Member

You'd need to make the rename globally; Also, I don't like that this just ignores -whitelistalwaysrelay set in old .conf files.

@MarcoFalke

MarcoFalke Jan 29, 2016

Member

You'd need to make the rename globally; Also, I don't like that this just ignores -whitelistalwaysrelay set in old .conf files.

This comment has been minimized.

@laanwj

laanwj Jan 30, 2016

Member

Valid point, although how old can these conf files be, given that whitelistalwaysrelay was introduced in #6993 only two months ago, so isn't in any releases.

@laanwj

laanwj Jan 30, 2016

Member

Valid point, although how old can these conf files be, given that whitelistalwaysrelay was introduced in #6993 only two months ago, so isn't in any releases.

This comment has been minimized.

@MarcoFalke

MarcoFalke Jan 30, 2016

Member

I guess there are three options:

@MarcoFalke

MarcoFalke Jan 30, 2016

Member

I guess there are three options:

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jan 29, 2016

Member

Concept ACK

Member

MarcoFalke commented Jan 29, 2016

Concept ACK

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jan 31, 2016

Contributor

utACK 325c725

Contributor

petertodd commented Jan 31, 2016

utACK 325c725

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 1, 2016

Member

Travis is failing, but I cannot quite see why.

Member

laanwj commented Feb 1, 2016

Travis is failing, but I cannot quite see why.

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Feb 1, 2016

Member

I think it started failing when I added the requested argument rejection. Does a test run with it? git grep yields nothing.

Member

gmaxwell commented Feb 1, 2016

I think it started failing when I added the requested argument rejection. Does a test run with it? git grep yields nothing.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 1, 2016

Member

utACK 89d113e. Thanks for sticking with this, I like the confs.

Member

MarcoFalke commented Feb 1, 2016

utACK 89d113e. Thanks for sticking with this, I like the confs.

@laanwj laanwj merged commit 89d113e into bitcoin:master Feb 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 1, 2016

Merge #7439: Add whitelistforcerelay to control forced relaying. [#7099
… redux]


89d113e Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay. (Gregory Maxwell)
325c725 Add whitelistforcerelay to control forced relaying. (Gregory Maxwell)

laanwj added a commit that referenced this pull request Feb 1, 2016

Add whitelistforcerelay to control forced relaying. [#7099 redux]
- Add whitelistforcerelay to control forced relaying.

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
 gets in the way of some useful reasons for whitelisting
 peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
 applications where a node is being used as a P2P connection
 filter and multiplexer, but where you don't want it getting
 in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.

- Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay.

Github-Pull: #7439
Rebased-From: 325c725 89d113e

@str4d str4d referenced this pull request in zcash/zcash Jul 14, 2017

Open

Bitcoin 0.12 P2P/Net PRs 1 #2534

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

@steven-bloom steven-bloom referenced this pull request in bitcoinfibre/bitcoinfibre Nov 29, 2017

Closed

Some instructions required #8

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

codablock added a commit to codablock/dash that referenced this pull request Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment