Add whitelistforcerelay to control forced relaying. [#7099 redux] #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renames whitelistalwaysrelay. Nodes relay all transactions from whitelisted peers, this gets in the way of some useful reasons for whitelisting peers-- for example, bypassing bandwidth limitations. The purpose of this forced relaying is for specialized gateway applications where a node is being used as a P2P connection filter and multiplexer, but where you don't want it getting in the way of (re-)broadcast. This change makes it configurable with whitelistforcerelay.
|
utACK 325c725 |
| @@ -752,13 +753,19 @@ void InitParameterInteraction() | |||
|
|
|||
| // disable walletbroadcast and whitelistalwaysrelay in blocksonly mode | |||
There was a problem hiding this comment.
You'd need to make the rename globally; Also, I don't like that this just ignores -whitelistalwaysrelay set in old .conf files.
There was a problem hiding this comment.
Valid point, although how old can these conf files be, given that whitelistalwaysrelay was introduced in #6993 only two months ago, so isn't in any releases.
There was a problem hiding this comment.
I guess there are three options:
- Silently accept both variations
- Ignore
- Add it to the blacklist https://github.com/gmaxwell/bitcoin/blob/325c725fb6205e38142914acb9ed1733d8482d46/src/init.cpp#L892-L903
|
Concept ACK |
|
utACK 325c725 |
|
Travis is failing, but I cannot quite see why. |
|
I think it started failing when I added the requested argument rejection. Does a test run with it? git grep yields nothing. |
|
utACK 89d113e. Thanks for sticking with this, I like the confs. |
laanwj
added a commit
that referenced
this pull request
Feb 1, 2016
laanwj
pushed a commit
that referenced
this pull request
Feb 1, 2016
- Add whitelistforcerelay to control forced relaying. Also renames whitelistalwaysrelay. Nodes relay all transactions from whitelisted peers, this gets in the way of some useful reasons for whitelisting peers-- for example, bypassing bandwidth limitations. The purpose of this forced relaying is for specialized gateway applications where a node is being used as a P2P connection filter and multiplexer, but where you don't want it getting in the way of (re-)broadcast. This change makes it configurable with whitelistforcerelay. - Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay. Github-Pull: #7439 Rebased-From: 325c725 89d113e
codablock
added a commit
to codablock/dash
that referenced
this pull request
Dec 9, 2017
Missed from bitcoin bitcoin#7439
codablock
added a commit
to codablock/dash
that referenced
this pull request
Dec 11, 2017
Missed from bitcoin bitcoin#7439
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 31, 2021
Add -blocksonly option Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6993 - bitcoin/bitcoin#7046 - bitcoin/bitcoin#6780 - The third commit (we backported the rest in #2390). - bitcoin/bitcoin#7126 - bitcoin/bitcoin#7439 - bitcoin/bitcoin#15990 - Only the `-blocksonly` documentation changes. - bitcoin/bitcoin#16555 - bitcoin/bitcoin#18391 - Only the `-blocksonly` documentation changes. Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renames whitelistalwaysrelay.
Nodes relay all transactions from whitelisted peers, this
gets in the way of some useful reasons for whitelisting
peers-- for example, bypassing bandwidth limitations.
The purpose of this forced relaying is for specialized gateway
applications where a node is being used as a P2P connection
filter and multiplexer, but where you don't want it getting
in the way of (re-)broadcast.
This change makes it configurable with whitelistforcerelay.