Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelistforcerelay to control forced relaying. [#7099 redux] #7439

Merged
merged 2 commits into from Feb 1, 2016
Merged

Add whitelistforcerelay to control forced relaying. [#7099 redux] #7439

merged 2 commits into from Feb 1, 2016

Conversation

gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Jan 28, 2016

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
gets in the way of some useful reasons for whitelisting
peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
applications where a node is being used as a P2P connection
filter and multiplexer, but where you don't want it getting
in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
 gets in the way of some useful reasons for whitelisting
 peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
 applications where a node is being used as a P2P connection
 filter and multiplexer, but where you don't want it getting
 in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.
@laanwj
Copy link
Member

laanwj commented Jan 29, 2016

utACK 325c725

@laanwj laanwj added this to the 0.12.0 milestone Jan 29, 2016
@@ -752,13 +753,19 @@ void InitParameterInteraction()

// disable walletbroadcast and whitelistalwaysrelay in blocksonly mode
Copy link
Member

@MarcoFalke MarcoFalke Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to make the rename globally; Also, I don't like that this just ignores -whitelistalwaysrelay set in old .conf files.

Copy link
Member

@laanwj laanwj Jan 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point, although how old can these conf files be, given that whitelistalwaysrelay was introduced in #6993 only two months ago, so isn't in any releases.

Copy link
Member

@MarcoFalke MarcoFalke Jan 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are three options:

@MarcoFalke
Copy link
Member

MarcoFalke commented Jan 29, 2016

Concept ACK

@petertodd
Copy link
Contributor

petertodd commented Jan 31, 2016

utACK 325c725

@laanwj
Copy link
Member

laanwj commented Feb 1, 2016

Travis is failing, but I cannot quite see why.

@gmaxwell
Copy link
Contributor Author

gmaxwell commented Feb 1, 2016

I think it started failing when I added the requested argument rejection. Does a test run with it? git grep yields nothing.

@MarcoFalke
Copy link
Member

MarcoFalke commented Feb 1, 2016

utACK 89d113e. Thanks for sticking with this, I like the confs.

@laanwj laanwj merged commit 89d113e into bitcoin:master Feb 1, 2016
1 check passed
laanwj added a commit that referenced this issue Feb 1, 2016
… redux]

89d113e Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay. (Gregory Maxwell)
325c725 Add whitelistforcerelay to control forced relaying. (Gregory Maxwell)
laanwj pushed a commit that referenced this issue Feb 1, 2016
- Add whitelistforcerelay to control forced relaying.

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
 gets in the way of some useful reasons for whitelisting
 peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
 applications where a node is being used as a P2P connection
 filter and multiplexer, but where you don't want it getting
 in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.

- Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay.

Github-Pull: #7439
Rebased-From: 325c725 89d113e
codablock added a commit to codablock/dash that referenced this issue Dec 9, 2017
codablock added a commit to codablock/dash that referenced this issue Dec 11, 2017
zkbot added a commit to zcash/zcash that referenced this issue Mar 31, 2021
Add -blocksonly option

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6993
- bitcoin/bitcoin#7046
- bitcoin/bitcoin#6780
  - The third commit (we backported the rest in #2390).
- bitcoin/bitcoin#7126
- bitcoin/bitcoin#7439
- bitcoin/bitcoin#15990
  - Only the `-blocksonly` documentation changes.
- bitcoin/bitcoin#16555
- bitcoin/bitcoin#18391
  - Only the `-blocksonly` documentation changes.

Part of #2074.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants