Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.12] Rename permitrbf to mempoolreplacement and provide minimal string-list forward compatibility #7440

merged 6 commits into from Feb 3, 2016


Copy link

@luke-jr luke-jr commented Jan 29, 2016

Backport of #7431

luke-jr added 4 commits Jan 29, 2016
"permit" is currently used to configure transaction filtering, whereas replacement is more to do with the memory pool state than the transaction itself.
Basic forward-compatibility with more flexible parameters like fss
@@ -144,13 +144,13 @@ accepted when it pays sufficient fee, as described in [BIP 125]

Transaction replacement can be disabled with a new command line option,
`-permitrbf=false`. Transactions signaling replacement under BIP125 will still
Copy link
Member Author

@luke-jr luke-jr Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdaftuar Note that "false" and "true" are invalid for boolean options!

@laanwj laanwj added this to the 0.12.0 milestone Feb 1, 2016
Copy link

MarcoFalke commented Feb 1, 2016

@luke-jr What about doing the same like 89d113e?

@luke-jr luke-jr changed the title [0.12] Rename permitrbf to replacebyfee and provide minimal string-list forward compatibility [0.12] Rename permitrbf to mempoolreplacement and provide minimal string-list forward compatibility Feb 1, 2016
Copy link

sandakersmann commented Feb 3, 2016

I think replacebyfee gives a better description of what this is.

Copy link
Member Author

luke-jr commented Feb 3, 2016

@sandakersmann The idea is that future or derivative versions may support more replacement logic than merely by fee. The original replacement feature was planned to simply go based on sequence number, but that had DoS risks - RBF solves that, but it's not impossible someone may come up with an alternative solution. Anyway, please use #7431 for comments on the change itself - this PR is merely a backport.

@laanwj laanwj merged commit af9f564 into bitcoin:0.12 Feb 3, 2016
laanwj added a commit that referenced this pull request Feb 3, 2016
…e minimal string-list forward compatibility

af9f564 release-notes: Update for replacebyfee->mempoolreplacement rename (Luke Dashjr)
4ad418b Rename replacebyfee=opt-in to mempoolreplacement=fee (Luke Dashjr)
b2287a7 release-notes: Update for permitrbf->replacebyfee rename (Luke Dashjr)
5f456a6 Simplify check for replacebyfee=opt-in (Luke Dashjr)
e8d19ab Accept replacebyfee=opt-in for turning on opt-in RBF (Luke Dashjr)
1205f87 Rename permitrbf to replacebyfee (Luke Dashjr)
@laanwj laanwj mentioned this pull request Feb 3, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants