New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Exit early when check-doc.py fails #7455

Merged
merged 1 commit into from Mar 3, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented Feb 1, 2016

Discussed on IRC

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 1, 2016

Member

Concept ACK.

Can we test this by making a dummy change and see if travis fails, and how it looks now?

Member

laanwj commented Feb 1, 2016

Concept ACK.

Can we test this by making a dummy change and see if travis fails, and how it looks now?

@laanwj laanwj added the Tests label Feb 1, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 1, 2016

Member

dummy change: https://travis-ci.org/bitcoin/bitcoin/builds/106296202

TBH, I don't like the set -e workaround, as the travis build will not exit cleanly. It doesn't matter with the current .travis.yml but it may in the future and it is not considered best practice.

Member

MarcoFalke commented Feb 1, 2016

dummy change: https://travis-ci.org/bitcoin/bitcoin/builds/106296202

TBH, I don't like the set -e workaround, as the travis build will not exit cleanly. It doesn't matter with the current .travis.yml but it may in the future and it is not considered best practice.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 2, 2016

Member

@theuni any ideas here? We want to terminate the test prematurely if the doc check fails, to avoid wasting resources, is there a nicer way to do this then set -e or exit?

Member

laanwj commented Feb 2, 2016

@theuni any ideas here? We want to terminate the test prematurely if the doc check fails, to avoid wasting resources, is there a nicer way to do this then set -e or exit?

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 2, 2016

Member

@laanwj You could "remember" the exit code and branch subsequent statements/lines but this is a somewhat larger diff, I guess.

Member

MarcoFalke commented Feb 2, 2016

@laanwj You could "remember" the exit code and branch subsequent statements/lines but this is a somewhat larger diff, I guess.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 26, 2016

Member

@laanwj The first commit should be uncontroversial and improve things considerably without making anything worse. Would you mind if I create a new pull for this commit?

Member

MarcoFalke commented Feb 26, 2016

@laanwj The first commit should be uncontroversial and improve things considerably without making anything worse. Would you mind if I create a new pull for this commit?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 2, 2016

Member

As this is a testing/build system related pull, I'd just like @theuni to take a look at it. If he's ok with it we'll just merge.

Member

laanwj commented Mar 2, 2016

As this is a testing/build system related pull, I'd just like @theuni to take a look at it. If he's ok with it we'll just merge.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 3, 2016

Member

@MarcoFalke I think it'd do what you wanted if you just bumped it up into before_script. Then you wouldn't have to worry about forcing an exit, as before_script errors the build on any non-zero return.

Member

theuni commented Mar 3, 2016

@MarcoFalke I think it'd do what you wanted if you just bumped it up into before_script. Then you wouldn't have to worry about forcing an exit, as before_script errors the build on any non-zero return.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 3, 2016

Member

other than that, ACK.

Member

theuni commented Mar 3, 2016

other than that, ACK.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 3, 2016

Member

Thanks for letting me know. This is indeed working: https://travis-ci.org/bitcoin/bitcoin/jobs/113383026

Member

MarcoFalke commented Mar 3, 2016

Thanks for letting me know. This is indeed working: https://travis-ci.org/bitcoin/bitcoin/jobs/113383026

@laanwj laanwj merged commit fa5f193 into bitcoin:master Mar 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 3, 2016

Merge #7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1601-travisCheckDoc branch Mar 3, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 11, 2017

Merge bitcoin#7455: [travis] Exit early when check-doc.py fails
fa5f193 [travis] Exit early when check-doc.py fails (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment