Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc-tests] Change solve() to use rehash #7468

Merged
merged 1 commit into from Feb 5, 2016

Conversation

mrbandrews
Copy link
Contributor

@mrbandrews mrbandrews commented Feb 4, 2016

Small fix to the p2p test framework (mininode, etc) that I ran into when belatedly testing PR 7225.

I think it's better for solve() to recompute the hash before the first attempt so we're not using a cached hash, which if wrong, would almost certainly be a bug in the test.

@laanwj laanwj added the Tests label Feb 4, 2016
@sdaftuar
Copy link
Member

sdaftuar commented Feb 4, 2016

utACK 7689041

This has bitten me before too...

@laanwj laanwj merged commit 7689041 into bitcoin:master Feb 5, 2016
laanwj added a commit that referenced this pull request Feb 5, 2016
7689041 [rpc-tests] Change solve() to use rehash (mrbandrews)
@laanwj
Copy link
Member

laanwj commented Feb 10, 2016

Cherry-picked to 0.12 as 947c4ff

laanwj pushed a commit that referenced this pull request Feb 10, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants