[rpc-tests] Change solve() to use rehash #7468

Merged
merged 1 commit into from Feb 5, 2016

Conversation

Projects
None yet
3 participants
@mrbandrews
Contributor

mrbandrews commented Feb 4, 2016

Small fix to the p2p test framework (mininode, etc) that I ran into when belatedly testing PR 7225.

I think it's better for solve() to recompute the hash before the first attempt so we're not using a cached hash, which if wrong, would almost certainly be a bug in the test.

@laanwj laanwj added the Tests label Feb 4, 2016

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Feb 4, 2016

Member

utACK 7689041

This has bitten me before too...

Member

sdaftuar commented Feb 4, 2016

utACK 7689041

This has bitten me before too...

@laanwj laanwj merged commit 7689041 into bitcoin:master Feb 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 5, 2016

Merge #7468: [rpc-tests] Change solve() to use rehash
7689041 [rpc-tests] Change solve() to use rehash (mrbandrews)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

Cherry-picked to 0.12 as 947c4ff

Member

laanwj commented Feb 10, 2016

Cherry-picked to 0.12 as 947c4ff

laanwj added a commit that referenced this pull request Feb 10, 2016

[rpc-tests] Change solve() to use rehash
Github-Pull: #7468
Rebased-From: 7689041

@laanwj laanwj removed the Needs backport label Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment