[rpc-tests] Change solve() to use rehash#7468
Merged
Merged
Conversation
Member
|
utACK 7689041 This has bitten me before too... |
laanwj
added a commit
that referenced
this pull request
Feb 5, 2016
7689041 [rpc-tests] Change solve() to use rehash (mrbandrews)
Member
|
Cherry-picked to 0.12 as 947c4ff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to the p2p test framework (mininode, etc) that I ran into when belatedly testing PR 7225.
I think it's better for solve() to recompute the hash before the first attempt so we're not using a cached hash, which if wrong, would almost certainly be a bug in the test.