rpc: Add WWW-Authenticate header to 401 response#7472
Merged
laanwj merged 1 commit intobitcoin:masterfrom Feb 9, 2016
Merged
Conversation
laanwj
force-pushed
the
2016_02_www_authenticate
branch
2 times, most recently
from
1e493fc to
5bac0a9
Compare
Contributor
|
👍 fixes Java's Authenticator as I reported in #7462 |
src/httprpc.cpp
Outdated
Member
There was a problem hiding this comment.
Nit:
diff --git a/src/httprpc.cpp b/src/httprpc.cpp
index 5d54d8f..a447a3e 100644
--- a/src/httprpc.cpp
+++ b/src/httprpc.cpp
@@ -25 +25 @@
-static const char *WWW_AUTH_HEADER_DATA = "Basic realm=\"jsonrpc\"";
+static const char* WWW_AUTH_HEADER_DATA = "Basic realm=\"jsonrpc\"";
@@ -157 +157 @@ static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
- req->WriteHeader("WWW-Authenticate",WWW_AUTH_HEADER_DATA);
+ req->WriteHeader("WWW-Authenticate", WWW_AUTH_HEADER_DATA);
@@ -170 +170 @@ static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
- req->WriteHeader("WWW-Authenticate",WWW_AUTH_HEADER_DATA);
+ req->WriteHeader("WWW-Authenticate", WWW_AUTH_HEADER_DATA);
Member
|
Concept ACK 5bac0a9 |
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.
WWW-Authenticate: Basic realm="jsonrpc"
Fixes bitcoin#7462.
laanwj
force-pushed
the
2016_02_www_authenticate
branch
from
5bac0a9 to
7c06fbd
Compare
Contributor
|
ACK laanwj@7c06fbd |
laanwj
added a commit
that referenced
this pull request
Feb 9, 2016
7c06fbd rpc: Add WWW-Authenticate header to 401 response (Wladimir J. van der Laan)
Member
Author
|
Cherry-picked to 0.12 as b2f2b85 |
This was referenced Jul 12, 2017
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jul 25, 2017
[rpc] Add WWW-Authenticate header to 401 response Fix cherry-picked from upstream PR bitcoin/bitcoin#7472. Closes #2444.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WWW-Authenticate header must be present in the 401 response to make clients know that they can authenticate, and how.
Should fix #7462.