New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed getnetworkhps value to double to avoid overflow. #7480

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Projects
None yet
5 participants
@instagibbs
Member

instagibbs commented Feb 8, 2016

Fixes #7476

@laanwj laanwj added the RPC/REST/ZMQ label Feb 8, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 8, 2016

Member

That was easy :)

utACK

Member

laanwj commented Feb 8, 2016

That was easy :)

utACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 8, 2016

Member

Tested ACK 993d089

I don't get why a cast to int was done in the first place.

Member

MarcoFalke commented Feb 8, 2016

Tested ACK 993d089

I don't get why a cast to int was done in the first place.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Feb 9, 2016

Contributor

utACK

Contributor

dcousens commented Feb 9, 2016

utACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Feb 9, 2016

Contributor

ACK instagibbs@993d089

Before:

$ btctest getnetworkhashps
1795134992997
$

After:

$ btctest getnetworkhashps
1795134992997.291
$
Contributor

paveljanik commented Feb 9, 2016

ACK instagibbs@993d089

Before:

$ btctest getnetworkhashps
1795134992997
$

After:

$ btctest getnetworkhashps
1795134992997.291
$
@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Feb 9, 2016

Contributor

We could still round the value if desired.

Contributor

dcousens commented Feb 9, 2016

We could still round the value if desired.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 9, 2016

Member

We could still round the value if desired.

Right, but I can't see how this could be desired as this would imply we have integer precision on the estimation, which is not true.

Member

MarcoFalke commented Feb 9, 2016

We could still round the value if desired.

Right, but I can't see how this could be desired as this would imply we have integer precision on the estimation, which is not true.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 9, 2016

Member

Agree with @MarcoFalke that rounding gives the wrong idea here that we actually know what the precision of this estimate is.

Member

laanwj commented Feb 9, 2016

Agree with @MarcoFalke that rounding gives the wrong idea here that we actually know what the precision of this estimate is.

@laanwj laanwj merged commit 993d089 into bitcoin:master Feb 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 9, 2016

Merge #7480: Changed getnetworkhps value to double to avoid overflow.
993d089 Changed getnetworkhps value to double to avoid overflow. (instagibbs)

laanwj added a commit that referenced this pull request Feb 10, 2016

@laanwj laanwj removed the Needs backport label Feb 10, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

Backported to 0.12 as c3faf78

Member

laanwj commented Feb 10, 2016

Backported to 0.12 as c3faf78

@dagurval dagurval referenced this pull request Mar 5, 2018

Merged

blockchain.py cherries #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment