New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] Ensure headers count is correct #7482

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Projects
None yet
3 participants
@sdaftuar
Member

sdaftuar commented Feb 8, 2016

This should be backported to 0.12.

Now that we're using headers announcements for new blocks, this makes sure that nQueuedValidatedHeaders is properly decremented when a peer disconnects.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 8, 2016

Member

utACK

Member

laanwj commented Feb 8, 2016

utACK

@morcos

This comment has been minimized.

Show comment
Hide comment
@morcos

morcos Feb 9, 2016

Member

ACK

Member

morcos commented Feb 9, 2016

ACK

@laanwj laanwj merged commit 301bc7b into bitcoin:master Feb 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 9, 2016

Merge #7482: [P2P] Ensure headers count is correct
301bc7b Update nQueuedValidatedHeaders after peer disconnection (Suhas Daftuar)

laanwj added a commit that referenced this pull request Feb 9, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

Was cherry-picked to 0.12 as e16f5b4

Member

laanwj commented Feb 10, 2016

Was cherry-picked to 0.12 as e16f5b4

@laanwj laanwj removed the Needs backport label Feb 10, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7482: [P2P] Ensure headers count is correct
301bc7b Update nQueuedValidatedHeaders after peer disconnection (Suhas Daftuar)

# Conflicts:
#	src/validation.cpp

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7482: [P2P] Ensure headers count is correct
301bc7b Update nQueuedValidatedHeaders after peer disconnection (Suhas Daftuar)

# Conflicts:
#	src/validation.cpp

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7482: [P2P] Ensure headers count is correct
301bc7b Update nQueuedValidatedHeaders after peer disconnection (Suhas Daftuar)

# Conflicts:
#	src/validation.cpp

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7482: [P2P] Ensure headers count is correct
301bc7b Update nQueuedValidatedHeaders after peer disconnection (Suhas Daftuar)

# Conflicts:
#	src/validation.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment