Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Render icons from SVG #7483
+91
−18
Conversation
luke-jr
added some commits
Feb 1, 2016
luke-jr
closed this
Feb 8, 2016
luke-jr
reopened this
Feb 8, 2016
luke-jr
closed this
Feb 8, 2016
luke-jr
reopened this
Feb 8, 2016
|
(Leaving it open for final branch updates/Travis testing) |
luke-jr
added some commits
Feb 6, 2016
|
Ok, this seems to be working good now. |
luke-jr
closed this
Feb 10, 2016
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 30, 2016
|
Why the instaclose? If it's good enough for Knots, then why wouldn't it be good enough for Core? And if it's not needed for Core, then why is it needed for Knots? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
luke-jr commentedFeb 8, 2016
This probably doesn't make sense to merge to Core itself due to the added dependencies (rsvg & imagemagick; and icnsutils for Mac) and risks (of installed rsvg mis-rendering the SVG), but posting it here (insta-close) for potential review and/or cherry-picking.