Render icons from SVG #7483

Closed
wants to merge 8 commits into
from

Projects

None yet

2 participants

@luke-jr
Member
luke-jr commented Feb 8, 2016

This probably doesn't make sense to merge to Core itself due to the added dependencies (rsvg & imagemagick; and icnsutils for Mac) and risks (of installed rsvg mis-rendering the SVG), but posting it here (insta-close) for potential review and/or cherry-picking.

@luke-jr luke-jr closed this Feb 8, 2016
@luke-jr luke-jr reopened this Feb 8, 2016
@luke-jr luke-jr closed this Feb 8, 2016
@luke-jr luke-jr reopened this Feb 8, 2016
@luke-jr
Member
luke-jr commented Feb 8, 2016

(Leaving it open for final branch updates/Travis testing)

@luke-jr
Member
luke-jr commented Feb 10, 2016

Ok, this seems to be working good now.

@luke-jr luke-jr closed this Feb 10, 2016
@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 30, 2016
@luke-jr luke-jr Merge #7483 svg_icon-0.12.x eddc4b2
@rebroad
Contributor
rebroad commented Sep 25, 2016 edited

Why the instaclose? If it's good enough for Knots, then why wouldn't it be good enough for Core? And if it's not needed for Core, then why is it needed for Knots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment