Render icons from SVG - #7483
Closed
luke-jr wants to merge 8 commits into
Closed
Conversation
icnsutils is needed on linux/win for generating the .icns in source tarball
Contributor
Author
|
(Leaving it open for final branch updates/Travis testing) |
luke-jr
force-pushed
the
svg_icon
branch
5 times, most recently
from
February 8, 2016 23:47
5c498ad to
04a28ef
Compare
luke-jr
force-pushed
the
svg_icon
branch
4 times, most recently
from
February 9, 2016 00:41
53ef003 to
ee7b660
Compare
Contributor
Author
|
Ok, this seems to be working good now. |
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 30, 2016
Contributor
|
Why the instaclose? If it's good enough for Knots, then why wouldn't it be good enough for Core? And if it's not needed for Core, then why is it needed for Knots? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably doesn't make sense to merge to Core itself due to the added dependencies (rsvg & imagemagick; and icnsutils for Mac) and risks (of installed rsvg mis-rendering the SVG), but posting it here (insta-close) for potential review and/or cherry-picking.