/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use system univalue by default #7485

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
3 participants
@luke-jr @laanwj @dcousens
@luke-jr
Member

luke-jr commented Feb 8, 2016

For future merging
@laanwj
Owner

laanwj commented Feb 8, 2016

Previous discussion was in #7349, where it was decided not to automatically use an installed univalue in favor of the included one.
@luke-jr
Member

luke-jr commented Feb 8, 2016

...for now.
@dcousens
Contributor

dcousens commented Feb 9, 2016

Why would you opt for system default? Out of interest.
@luke-jr
Member

luke-jr commented Feb 9, 2016

Standard best practices. Libraries shouldn't be bundled at all. We have a reasonable case for bundling consensus-critical ones like LevelDB and libsecp256k1, but Univalue is not consensus-critical at all.

@laanwj laanwj added the Build system label Feb 10, 2016

@laanwj
Owner

laanwj commented Apr 1, 2016

We're not going to do this (at least for the forseeable future), so closing for now.

@laanwj laanwj closed this Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment