New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system univalue by default #7485

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@luke-jr
Member

luke-jr commented Feb 8, 2016

For future merging

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 8, 2016

Member

Previous discussion was in #7349, where it was decided not to automatically use an installed univalue in favor of the included one.

Member

laanwj commented Feb 8, 2016

Previous discussion was in #7349, where it was decided not to automatically use an installed univalue in favor of the included one.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Feb 8, 2016

Member

...for now.

Member

luke-jr commented Feb 8, 2016

...for now.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Feb 9, 2016

Contributor

Why would you opt for system default? Out of interest.

Contributor

dcousens commented Feb 9, 2016

Why would you opt for system default? Out of interest.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Feb 9, 2016

Member

Standard best practices. Libraries shouldn't be bundled at all. We have a reasonable case for bundling consensus-critical ones like LevelDB and libsecp256k1, but Univalue is not consensus-critical at all.

Member

luke-jr commented Feb 9, 2016

Standard best practices. Libraries shouldn't be bundled at all. We have a reasonable case for bundling consensus-critical ones like LevelDB and libsecp256k1, but Univalue is not consensus-critical at all.

@laanwj laanwj added the Build system label Feb 10, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 1, 2016

Member

We're not going to do this (at least for the forseeable future), so closing for now.

Member

laanwj commented Apr 1, 2016

We're not going to do this (at least for the forseeable future), so closing for now.

@laanwj laanwj closed this Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment