/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Workaround Travis-side CI issues #7487

Merged
merged 4 commits into from Feb 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Build system Tests
Projects
None yet
Milestone
No milestone
5 participants
@luke-jr @laanwj @dcousens @btcdrak @MarcoFalke
@luke-jr
Member

luke-jr commented Feb 9, 2016

Currently Travis's wget fails fetching qrencode:

Fetching qrencode...
ERROR: no certificate subject alternative name matches
    requested host name `fukuchi.org'.
To connect to fukuchi.org insecurely, use `--no-check-certificate'.
OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
Unable to establish SSL connection.
make: *** [/home/travis/build/luke-jr/bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-3.4.4.tar.bz2.hash] Error 4

luke-jr added some commits Feb 9, 2016

@luke-jr
depends: Use curl for fetching on Linux 
Currently Travis's wget fails fetching qrencode:

Fetching qrencode...
ERROR: no certificate subject alternative name matches
	requested host name `fukuchi.org'.
To connect to fukuchi.org insecurely, use `--no-check-certificate'.
OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
Unable to establish SSL connection.
make: *** [/home/travis/build/luke-jr/bitcoin/depends/sources/download-stamps/.stamp_fetched-qrencode-qrencode-3.4.4.tar.bz2.hash] Error 4
1ecbb3b
@luke-jr
Travis: Use curl rather than wget for Mac SDK
5d1148c
@laanwj
Owner

laanwj commented Feb 9, 2016

What wonders me most is why it won't try the fallback URL
@luke-jr
Member

luke-jr commented Feb 9, 2016

Not sure, but even if it did, it would fail. Note the second commit I had to add for the OSX SDK on bitcoincore.org :/
@laanwj
Owner

laanwj commented Feb 9, 2016

Why is the MacOSX SDK download broken too?

I don't think I understand what is the issue here. Is that site irrevocably broken, or is there some certificate issue? (e.g. missing ca-certificates package?) But in that case you'd expect any tool to fail.

Switching to another tool is possible but I'd like to know what is wrong first. It seems like a heavy-handed solution.

@theuni any idea?
@luke-jr
Member

luke-jr commented Feb 9, 2016

Seems to be a wget bug in the ancient 12.02 Ubuntu that Travis uses. But I could be wrong.

@laanwj laanwj added Build system Tests labels Feb 9, 2016

@laanwj
Owner

laanwj commented Feb 9, 2016

Bleh. We need 14.04 support for other reasons too (e.g. c++11).
@luke-jr
Member

luke-jr commented Feb 9, 2016

It looks like 14.04 is possible, but... only be losing IPv6 localhost support [again]. :/
@dcousens
Contributor

dcousens commented Feb 9, 2016

concept ACK
@luke-jr
Member

luke-jr commented Feb 9, 2016

Note: curl needs -L to follow redirects.
@luke-jr
Member

luke-jr commented Feb 10, 2016

This fixes the Travis-side CI issues: https://travis-ci.org/luke-jr/bitcoin/builds/108146026

@luke-jr luke-jr changed the title from depends: Use curl for fetching on Linux to Workaround Travis-side CI issues Feb 10, 2016

@btcdrak
Member

btcdrak commented Feb 10, 2016

utACK, agree on using curl

@MarcoFalke MarcoFalke commented on the diff Feb 13, 2016

View full changes
depends/builders/linux.mk
@@ -1,2 +1,2 @@
build_linux_SHA256SUM = sha256sum
-build_linux_DOWNLOAD = wget --timeout=$(DOWNLOAD_CONNECT_TIMEOUT) --tries=$(DOWNLOAD_RETRIES) -nv -O
+build_linux_DOWNLOAD = curl --location --fail --connect-timeout $(DOWNLOAD_CONNECT_TIMEOUT) --retry $(DOWNLOAD_RETRIES) -L -o
@MarcoFalke

MarcoFalke Feb 13, 2016

Member

Is it required to set --location and -L?
@MarcoFalke
Member

MarcoFalke commented Feb 13, 2016

utACK c01f08d

@laanwj laanwj merged commit 149641e into bitcoin:master Feb 15, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 15, 2016

@laanwj
Merge #7487: Workaround Travis-side CI issues 
149641e Travis: Use Blue Box VMs for IPv6 loopback support (Luke Dashjr)
c01f08d Bugfix: depends/Travis: Use --location (follow redirects) and --fail [on HTTP error response] with curl (Luke Dashjr)
5d1148c Travis: Use curl rather than wget for Mac SDK (Luke Dashjr)
1ecbb3b depends: Use curl for fetching on Linux (Luke Dashjr)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
bf1e113

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 26, 2016

@luke-jr @MarcoFalke
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
6bf4884

laanwj added a commit that referenced this pull request Mar 1, 2016

@luke-jr @laanwj
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
00d57b4

laanwj added a commit that referenced this pull request Mar 1, 2016

@luke-jr @laanwj
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
77841d4

schinzelh added a commit to dashpay/dash that referenced this pull request Mar 7, 2016

@luke-jr @schinzelh
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
3c36bcf

dexX7 added a commit to dexX7/bitcoin that referenced this pull request Apr 24, 2016

@luke-jr @dexX7
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b

---

Removed sudo, dist and group, because we are on a different box.
This commit was signed with a verified signature.
@dexX7 dexX7
GPG key ID: 7675E31CF5719832 Learn about signing commits
5a8b92b

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request May 12, 2016

@luke-jr
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Cherry-pick-From: 00d57b4
79b6425

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Jun 2, 2016

@luke-jr
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Cherry-pick-From: 00d57b4
128c5e1

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2016

@luke-jr
Null-Merge #7487 depends_curl: Already in v0.12.1
85e0adf

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 18, 2016

@luke-jr
Null-Merge #7487 depends_curl: Already in v0.12.1
536812c

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Oct 4, 2016

@luke-jr
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Cherry-pick-From: 00d57b4
98a2f26

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 22, 2016

@luke-jr @nomnombtc
Workaround Travis-side CI issues 
Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b
Cherry-pick-From: 00d57b4
c56af5a

@langerhans langerhans referenced this pull request in dogecoin/dogecoin Dec 11, 2016

Merged

[depends] fix multiple depends url issues #1358

tempgit9 pushed a commit to tempgit9/bitcoin that referenced this pull request Jan 16, 2017

@romanornr
Merge remote-tracking branch 'bitcoin/0.10' (#42) 
* Fix url in .travis.yml

Github-Pull: #7136
Rebased-From: 9999cb0

* Workaround Travis-side CI issues

Github-Pull: #7487
Rebased-From: 149641e c01f08d 5d1148c 1ecbb3b

* [depends] builders: No need to set -L and --location for curl

Github-Pull: #7606
Rebased-From: fa7a5c5

* Bugfix: gitian: Add curl to packages (now needed for depends)

Conflicts:
	contrib/gitian-descriptors/gitian-osx.yml
Github-Pull: #7614
Rebased-From: 5c70a6d
66c5ffb

@str4d str4d referenced this pull request in zcash/zcash Oct 29, 2017

Open

Darwin build fixes #2697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment