New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Make proxy_test work on travis servers without IPv6 #7489

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
3 participants
@laanwj
Member

laanwj commented Feb 9, 2016

I'm embarrassed to have to write something like this in 2016, but it appears the new Travis servers with Ubuntu Trusty have no support for IPv6 (not even localhost!). Thus this pull checks for IPv6 and skips the IPv6 tests if the environment is lacking it.

As we need trusty support for c++11 at some point, we'll need this.

Ref:

@laanwj laanwj added the Tests label Feb 9, 2016

self.conf3.unauth = True
self.conf3.auth = True
else:
print "Warning: testing without local IPv6 support"

This comment has been minimized.

@luke-jr

luke-jr Feb 9, 2016

Member
print("Warning: testing without local IPv6 support")

Parenthesis needed for Py3 support.

@luke-jr

luke-jr Feb 9, 2016

Member
print("Warning: testing without local IPv6 support")

Parenthesis needed for Py3 support.

This comment has been minimized.

@laanwj

laanwj Feb 9, 2016

Member

Is there any python 3 compatibility at all? Adding parenthesis without the proper __future__ import will result in wacky output (in general - in this specific case, there is only one argument so it won't be printed as a string tuple).
Probably should make

from __future__ import division,print_function,unicode_literals

mandatory for all python scripts (but not here).

@laanwj

laanwj Feb 9, 2016

Member

Is there any python 3 compatibility at all? Adding parenthesis without the proper __future__ import will result in wacky output (in general - in this specific case, there is only one argument so it won't be printed as a string tuple).
Probably should make

from __future__ import division,print_function,unicode_literals

mandatory for all python scripts (but not here).

This comment has been minimized.

@luke-jr

luke-jr Feb 10, 2016

Member

Is there any python 3 compatibility at all?

Probably not, but let's not make it worse?

Adding parenthesis without the proper future import will result in wacky output (in general - in this specific case, there is only one argument so it won't be printed as a string tuple).

How so? There is only ever one argument to print, right?

@luke-jr

luke-jr Feb 10, 2016

Member

Is there any python 3 compatibility at all?

Probably not, but let's not make it worse?

Adding parenthesis without the proper future import will result in wacky output (in general - in this specific case, there is only one argument so it won't be printed as a string tuple).

How so? There is only ever one argument to print, right?

This comment has been minimized.

@laanwj

laanwj Feb 10, 2016

Member

How so? There is only ever one argument to print, right?

Yes, but it is deceptive. It looks like a python3 print function, but when you add an argument it start to behave differently in py2 and py3.
I'm ok with making the tests Python 3 compatible, but I'm not going to do so it in this pull.

@laanwj

laanwj Feb 10, 2016

Member

How so? There is only ever one argument to print, right?

Yes, but it is deceptive. It looks like a python3 print function, but when you add an argument it start to behave differently in py2 and py3.
I'm ok with making the tests Python 3 compatible, but I'm not going to do so it in this pull.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 16, 2016

Member

Is this still relevant @luke-jr @theuni, or has the ipv6 problem been solved?

Member

laanwj commented Mar 16, 2016

Is this still relevant @luke-jr @theuni, or has the ipv6 problem been solved?

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 17, 2016

Member

@laanwj Afaik nothing's changed here wrt Travis

Member

theuni commented Mar 17, 2016

@laanwj Afaik nothing's changed here wrt Travis

@laanwj laanwj merged commit 7539f1a into bitcoin:master Apr 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 1, 2016

Merge #7489: tests: Make proxy_test work on travis servers without IPv6
7539f1a tests: Make proxy_test work on travis servers without IPv6 (Wladimir J. van der Laan)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request May 11, 2016

@braydonf braydonf referenced this pull request May 11, 2016

Merged

tests: fix travis build #9

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Jun 2, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

braydonf pushed a commit to braydonf/bitcoin that referenced this pull request Oct 4, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 22, 2016

sickpig referenced this pull request in sickpig/BitcoinUnlimited Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment