New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wallet best block marker when pruning #7502

Merged
merged 1 commit into from Feb 10, 2016

Conversation

Projects
None yet
4 participants
@sipa
Member

sipa commented Feb 10, 2016

When pruning, make sure that we update the wallet best block before deleting any files.

@laanwj laanwj added the Wallet label Feb 10, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

utACK

Note: intended to fix #7494.

Member

laanwj commented Feb 10, 2016

utACK

Note: intended to fix #7494.

@sipa sipa changed the title from Update the wallet best block marker before pruning to Update the wallet best block marker when pruning Feb 10, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Feb 10, 2016

Member

Updated the logic to just always update the wallet best block when the chainstate is flushed. Both are relatively slow operations, so this shouldn't have a strong effect on performance.

There are further problems with the flushing logic, which will require a more invasive change, but those problems can only trigger when a crash during flushing happens.

Member

sipa commented Feb 10, 2016

Updated the logic to just always update the wallet best block when the chainstate is flushed. Both are relatively slow operations, so this shouldn't have a strong effect on performance.

There are further problems with the flushing logic, which will require a more invasive change, but those problems can only trigger when a crash during flushing happens.

@morcos

This comment has been minimized.

Show comment
Hide comment
@morcos

morcos Feb 10, 2016

Member

utACK

Member

morcos commented Feb 10, 2016

utACK

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Feb 10, 2016

Member

utACK. Needs backport!

Member

sdaftuar commented Feb 10, 2016

utACK. Needs backport!

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Feb 10, 2016

Member

Verified that I can trigger the problem reported in #7494 by stopping bitcoind cleanly after the first blocks are pruned (restarting then fails).

Verified further that this pull fixes the issue.

ACK e4eebb6

Member

sdaftuar commented Feb 10, 2016

Verified that I can trigger the problem reported in #7494 by stopping bitcoind cleanly after the first blocks are pruned (restarting then fails).

Verified further that this pull fixes the issue.

ACK e4eebb6

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

@sdaftuar thanks for testing!

Member

laanwj commented Feb 10, 2016

@sdaftuar thanks for testing!

@laanwj laanwj merged commit e4eebb6 into bitcoin:master Feb 10, 2016

laanwj added a commit that referenced this pull request Feb 10, 2016

Merge #7502: Update the wallet best block marker when pruning
e4eebb6 Update the wallet best block marker when pruning (Pieter Wuille)

laanwj added a commit that referenced this pull request Feb 10, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 10, 2016

Member

Cherry-picked to 0.12 as 1329963

Member

laanwj commented Feb 10, 2016

Cherry-picked to 0.12 as 1329963

@laanwj laanwj removed the Needs backport label Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment