Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
test: script_error checking in script_invalid tests #7517
Check the returned script_error. Add expected script_error for generated as well as custom tests.
The specific error is not part of consensus, however it could avoid unclear reporting issues such as #6862 in the future. It also makes it easier to verify that all potential error conditions are checked.
It also reveals that overflow conditions return
Changes are best reviewed using
These are not returned in any of the script tests:
ScriptErrorString returns a more extended, human readable error message. Personally I prefer these constant names: