New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Warn on unexpected EOF while salvaging wallet #7537

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
4 participants
@laanwj
Member

laanwj commented Feb 15, 2016

Check for EOF before every getline, and warn when reading gets to EOF before the end of the data.

Also check when number of keys does not match number of values.

Stricter error checking could shed more light on issues such as #7463 and #7379.

@laanwj laanwj added the Wallet label Feb 15, 2016

wallet: Warn on unexpected EOF while salvaging wallet
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.

Stricter error checking could shed more light on issues such as #7463
and #7379.
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik commented on ca8fb59 Feb 15, 2016

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Feb 19, 2016

utACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 27, 2016

Member

utACK ca8fb59

Edit: I got this once now:

2016-02-27 18:15:43 Renamed wallet.dat to wallet.1456596943.bak
2016-02-27 18:15:43 CDBEnv::Salvage: Database salvage found errors, all data may not be recoverable.
2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Number of keys in data does not match number of values.
2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Unexpected end of file while reading salvage output.
2016-02-27 18:15:43 Salvage(aggressive) found 300 records
Member

MarcoFalke commented Feb 27, 2016

utACK ca8fb59

Edit: I got this once now:

2016-02-27 18:15:43 Renamed wallet.dat to wallet.1456596943.bak
2016-02-27 18:15:43 CDBEnv::Salvage: Database salvage found errors, all data may not be recoverable.
2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Number of keys in data does not match number of values.
2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Unexpected end of file while reading salvage output.
2016-02-27 18:15:43 Salvage(aggressive) found 300 records

@laanwj laanwj merged commit ca8fb59 into bitcoin:master Feb 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 29, 2016

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 11, 2017

Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet
ca8fb59 wallet: Warn on unexpected EOF while salvaging wallet (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment