New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to mempool's mapTx indices #7539

Merged
merged 1 commit into from Mar 5, 2016

Conversation

Projects
None yet
5 participants
@sdaftuar
Member

sdaftuar commented Feb 16, 2016

This is a small refactor to how we use the boost multi_index in CTxMemPool -- rather than have to use fixed index numbers in our code, I added some tags so that we can use logical names instead, so that e.g. nth_index<2> becomes index<entry_time>.

This was motivated by me rebasing some old work on to master, and I realized that the usage of fixed indices was error prone.

I didn't bother with a tag name for the zero-th index (txid), since nothing seems to explicitly use it, but I can add one if people think that'd be better.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Feb 16, 2016

Member

utACK

Member

sipa commented Feb 16, 2016

utACK

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Feb 16, 2016

Contributor

utACK 086da92

Contributor

dcousens commented Feb 16, 2016

utACK 086da92

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Feb 23, 2016

Member

ping. If this looks fine to everyone it would be nice to have this merged, as it'll make some work I hope to PR soon on top of this somewhat cleaner.

Member

sdaftuar commented Feb 23, 2016

ping. If this looks fine to everyone it would be nice to have this merged, as it'll make some work I hope to PR soon on top of this somewhat cleaner.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Feb 25, 2016

Member

Concept ACK

Member

luke-jr commented Feb 25, 2016

Concept ACK

@sipa sipa merged commit 086da92 into bitcoin:master Mar 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Mar 5, 2016

Merge #7539: Add tags to mempool's mapTx indices
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)

@kyuupichan kyuupichan referenced this pull request Mar 4, 2017

Closed

Backports to miner.cpp #334

@kyuupichan kyuupichan referenced this pull request Mar 19, 2017

Merged

Miner backport #380

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7539: Add tags to mempool's mapTx indices
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7539: Add tags to mempool's mapTx indices
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7539: Add tags to mempool's mapTx indices
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7539: Add tags to mempool's mapTx indices
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment