/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove vfReachable and modify IsReachable to only use vfLimited. #7553

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
5 participants
@pstratem @laanwj @theuni @sipa @MarcoFalke
@pstratem
Contributor

pstratem commented Feb 18, 2016

We do not know that a class of Network is reachable, only that it is not.
@pstratem
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.
110b62f

@laanwj laanwj added the P2P label Feb 18, 2016

@laanwj
Owner

laanwj commented Feb 18, 2016

Possibly related issue, there's some discussion there:

  • Addrman only contains seed nodes when there's no externally bound address #7098 @theuni

Concept ACK, I don't think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this.
@pstratem
Contributor

pstratem commented Feb 18, 2016

@laanwj Yes this will fix that issue.

onlynet and proxy settings are unaffected
@laanwj
Owner

laanwj commented Feb 29, 2016

@theuni can you please take a look here, as you performed investigation in #7098. Do you see problems with this solution?
@theuni
Member

theuni commented Mar 1, 2016

Concept ack, trying to balance the two was confusing.
Quick code review ack as well.
@sipa
Owner

sipa commented Mar 5, 2016

Concept ACK

@laanwj laanwj added the Needs backport label Mar 11, 2016

@laanwj laanwj merged commit 110b62f into bitcoin:master Mar 11, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 11, 2016

@laanwj
Merge #7553: Remove vfReachable and modify IsReachable to only use vf… 
…Limited.


110b62f Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
9f14e5a

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

@pstratem @MarcoFalke
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
a5bc6a1
@MarcoFalke
Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

@MarcoFalke MarcoFalke removed the Needs backport label Jun 9, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

@pstratem @zander
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
8a1df01

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

@pstratem @thokon00
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
85b0c2a

@pinheadmz pinheadmz referenced this pull request in BitcoinUnlimited/BitcoinUnlimited Oct 12, 2016

Closed

getnetworkinfo: networks: reachable: all false, old bug from core #116

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@pstratem @nomnombtc
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
2bb5711

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@pstratem @nomnombtc
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
4323871

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@pstratem @nomnombtc
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
1aff96d

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@pstratem @nomnombtc
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
84150a9

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 14, 2016

@pstratem @nomnombtc
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
f30df51

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

@pstratem @sickpig
Remove vfReachable and modify IsReachable to only use vfLimited. 
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
This commit was signed with a verified signature.
@sickpig sickpig Andrea Suisani
GPG key ID: A9CA1D0EE3789741 Learn about signing commits
98d95ff

@str4d str4d referenced this pull request in zcash/zcash Mar 24, 2017

Merged

Tor ephemeral hidden services #2177

zkbot added a commit to zcash/zcash that referenced this pull request Mar 26, 2017

@zkbot
Auto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira 
Tor ephemeral hidden services

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6503 (included to reduce merge conflicts)
- bitcoin/bitcoin#6639
- bitcoin/bitcoin#6643
- bitcoin/bitcoin#7090
- bitcoin/bitcoin#7035
- bitcoin/bitcoin#7170
- bitcoin/bitcoin#7218 (non-QT part)
- bitcoin/bitcoin#7313
- bitcoin/bitcoin#7438
- bitcoin/bitcoin#7553
- bitcoin/bitcoin#7637
- bitcoin/bitcoin#7683
- bitcoin/bitcoin#7813
- bitcoin/bitcoin#7703
- bitcoin/bitcoin#8203
- bitcoin/bitcoin#9004
- bitcoin/bitcoin#9234
- bitcoin/bitcoin#9911 (partial)

Closes #2061.
45faa92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment