New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vfReachable and modify IsReachable to only use vfLimited. #7553

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
5 participants
@pstratem
Contributor

pstratem commented Feb 18, 2016

We do not know that a class of Network is reachable, only that it is not.

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

@laanwj laanwj added the P2P label Feb 18, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 18, 2016

Member

Possibly related issue, there's some discussion there:

  • Addrman only contains seed nodes when there's no externally bound address #7098 @theuni

Concept ACK, I don't think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this.

Member

laanwj commented Feb 18, 2016

Possibly related issue, there's some discussion there:

  • Addrman only contains seed nodes when there's no externally bound address #7098 @theuni

Concept ACK, I don't think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this.

@pstratem

This comment has been minimized.

Show comment
Hide comment
@pstratem

pstratem Feb 18, 2016

Contributor

@laanwj Yes this will fix that issue.

onlynet and proxy settings are unaffected

Contributor

pstratem commented Feb 18, 2016

@laanwj Yes this will fix that issue.

onlynet and proxy settings are unaffected

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 29, 2016

Member

@theuni can you please take a look here, as you performed investigation in #7098. Do you see problems with this solution?

Member

laanwj commented Feb 29, 2016

@theuni can you please take a look here, as you performed investigation in #7098. Do you see problems with this solution?

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 1, 2016

Member

Concept ack, trying to balance the two was confusing.
Quick code review ack as well.

Member

theuni commented Mar 1, 2016

Concept ack, trying to balance the two was confusing.
Quick code review ack as well.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 5, 2016

Member

Concept ACK

Member

sipa commented Mar 5, 2016

Concept ACK

@laanwj laanwj merged commit 110b62f into bitcoin:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 11, 2016

Merge #7553: Remove vfReachable and modify IsReachable to only use vf…
…Limited.

110b62f Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 9, 2016

Member

Backported as part of #7938. Removing label 'Needs backport'.

Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 14, 2016

Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment