New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] move wallet help string creation to CWallet #7576

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
6 participants
@jonasschnelli
Member

jonasschnelli commented Feb 22, 2016

Simple and easy-to-review refactoring to reduce wallets init.cpp polution and sets another step in the wallet separation / duplication.

The only visible change to users would be, that the wallet help message part has now it's own -help-debug part (IMO desirable if we look at the wallet as it is a module)

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Feb 22, 2016

Contributor

ACK (please fix the typo).

Contributor

paveljanik commented Feb 22, 2016

ACK (please fix the typo).

@kirkalx

This comment has been minimized.

Show comment
Hide comment
@kirkalx

kirkalx Feb 22, 2016

Contributor

Nice, utACK.

Contributor

kirkalx commented Feb 22, 2016

Nice, utACK.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 26, 2016

Member

Looks good. utACK acf7f87

Member

MarcoFalke commented Feb 26, 2016

Looks good. utACK acf7f87

@laanwj

View changes

Show outdated Hide outdated src/wallet/wallet.h
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 1, 2016

Member

utACK apart from nit - great idea.

Member

laanwj commented Mar 1, 2016

utACK apart from nit - great idea.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 5, 2016

Member

Concept ACK, but fix @laanwj's nit and the typo.

Member

sipa commented Mar 5, 2016

Concept ACK, but fix @laanwj's nit and the typo.

@MarcoFalke

View changes

Show outdated Hide outdated src/wallet/wallet.h
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 5, 2016

Member

Fixed nit (amend force push)

Member

jonasschnelli commented Mar 5, 2016

Fixed nit (amend force push)

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 5, 2016

utACK 72c2651

@laanwj laanwj merged commit 72c2651 into bitcoin:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 11, 2016

Merge #7576: [Wallet] move wallet help string creation to CWallet
72c2651 [Wallet] move wallet help string creation to CWallet (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7576: [Wallet] move wallet help string creation to CWallet
72c2651 [Wallet] move wallet help string creation to CWallet (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7576: [Wallet] move wallet help string creation to CWallet
72c2651 [Wallet] move wallet help string creation to CWallet (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7576: [Wallet] move wallet help string creation to CWallet
72c2651 [Wallet] move wallet help string creation to CWallet (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7576: [Wallet] move wallet help string creation to CWallet
72c2651 [Wallet] move wallet help string creation to CWallet (Jonas Schnelli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment