New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: Re-remove ERROR logging for mempool rejects #7592

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Feb 24, 2016

Continues "Make logging for validation optional" from #6519.

The idea there was to remove all ERROR logging of rejected transaction, and move it to one message in the class 'mempoolrej' which logs the state message (and debug info). The superfluous ERRORs in the log "terrify" users, see for example issue #5794.

Unfortunately a lot of new logging was introduced in #6871 (RBF) and #7287 (misc refactoring) without taking this into account, for example:

2016-02-24 18:28:45 ERROR: AcceptToMemoryPoolWorker: CheckInputs: ae5ca485da7464f211aa314c37f6c7c5a1807807dc448cba187bce0c214e8853, non-mandatory-script-verify-flag (Non-canonical signature: S value is unnecessarily high) (code 64)

This pull updates that new code.

mempool: Reduce ERROR logging for mempool rejects
Continues "Make logging for validation optional" from #6519.

The idea there was to remove all ERROR logging of rejected transaction,
and move it to one message in the class 'mempoolrej' which logs the
state message (and debug info). The superfluous ERRORs in the log
"terrify" users, see for example issue #5794.

Unfortunately a lot of new logging was introduced in #6871 (RBF) and
 #7287 (misc refactoring). This pull updates that new code.

@laanwj laanwj changed the title from mempool: Reduce ERROR logging for mempool rejects to mempool: Re-remove ERROR logging for mempool rejects Feb 29, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 5, 2016

Member

utACK

Member

sipa commented Mar 5, 2016

utACK

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon Mar 5, 2016

Member

UtACK

Member

jtimon commented Mar 5, 2016

UtACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 5, 2016

Contributor

ACK

Contributor

paveljanik commented Mar 5, 2016

ACK

@laanwj laanwj merged commit 8fc81e0 into bitcoin:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 11, 2016

Merge #7592: mempool: Re-remove ERROR logging for mempool rejects
8fc81e0 mempool: Reduce ERROR logging for mempool rejects (Wladimir J. van der Laan)

@laanwj laanwj removed the Needs backport label Sep 26, 2016

@laanwj laanwj added this to the 0.12.2 milestone Sep 26, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7592: mempool: Re-remove ERROR logging for mempool rejects
8fc81e0 mempool: Reduce ERROR logging for mempool rejects (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7592: mempool: Re-remove ERROR logging for mempool rejects
8fc81e0 mempool: Reduce ERROR logging for mempool rejects (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7592: mempool: Re-remove ERROR logging for mempool rejects
8fc81e0 mempool: Reduce ERROR logging for mempool rejects (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7592: mempool: Re-remove ERROR logging for mempool rejects
8fc81e0 mempool: Reduce ERROR logging for mempool rejects (Wladimir J. van der Laan)

@fanquake fanquake removed the Needs backport label Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment