Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
All files related to my RPM spec file project in one commit #7609
This is an attempt at the former pull request - #7588 (comment) - as a single commit.
The RPM package manager is used by several Linux distributions.
This provides an RPM spec file that is clean and builds properly on CentOS 7 (RHEL 7 clone) and should hopefully easily facilitate building RPM packages on other platforms as well.
It defaults to building against OpenSSL and the Qt5 GUI toolkit, but it supports switches that allow easily building against LibreSSL and/or Qt4 and/no no GUI.
See the README.md file in the contrib/rpm directory for more details.
I just wanted to clarify a note about the spec file and the generation of PNG / XPM images in the spec file.
The reason for that, the Source0 specifies the release tarball rather than github tagged release. The PNG / XPM files in github are not in the release tarball, so it was either list 10 additional github sources for them or list one additional vector source for the graphic and generate the icons from it.
I chose the latter.
Mar 24, 2016
1 check passed
added a commit
this pull request
Mar 24, 2016
I wish I saw this earlier. This RPM spec is far from clean, the quality of the .spec is quite poor and it would not pass any package review standards (like Fedora). I also question why it encourages and offers to patch out the build-time prohibition of libressl which was intentionally disabled in Bitcoin.
I do not advise going further with better automating this with a
I would suggest that we separate out the SELinux policy into a different directory and discuss what that should do. The SELinux policy shipped in an upstream source repo should have documentation of what it is meant to be allowed or disallowed, in addition to a security review like any other code would be reviewed to confirm that it actually meets the stated goals.
Related discussion: https://bugzilla.redhat.com/show_bug.cgi?id=1020292
If this is WIP, why was it committed to the core repo? In any case it's fine to exist here, I will just suggest that people ignore it because it is of poor quality. I don't think "fixing" it in the core repo is a good idea because you can't make a RPM spec that is valid on all distros.