New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] Delete unused patches #7616

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Feb 27, 2016

No description provided.

@MarcoFalke MarcoFalke changed the title from Revert "depends: fix Boost 1.55 build on GCC 5" to [depends] Revert "fix Boost 1.55 build on GCC 5" Feb 27, 2016

@MarcoFalke MarcoFalke changed the title from [depends] Revert "fix Boost 1.55 build on GCC 5" to [depends] Delete unused patches Feb 27, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Feb 28, 2016

Member

utACK fab4e7641c7e14634a7d8f13904054d6bd608ff4
ping @theuni

Member

jonasschnelli commented Feb 28, 2016

utACK fab4e7641c7e14634a7d8f13904054d6bd608ff4
ping @theuni

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Feb 29, 2016

Member

Can you please be a bit more verbose in your commit message:

  • Why were these patches there
  • Why are they no longer needed
Member

laanwj commented Feb 29, 2016

Can you please be a bit more verbose in your commit message:

  • Why were these patches there
  • Why are they no longer needed
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Feb 29, 2016

Member

The patches are no longer used since 4bdad99#diff-348b8d945e85fb166a4cf611fa2e2f99L29. Also, I suspect they are bit rotten as we bumped to 1.59 already.

Edit: added to commit description

Member

MarcoFalke commented Feb 29, 2016

The patches are no longer used since 4bdad99#diff-348b8d945e85fb166a4cf611fa2e2f99L29. Also, I suspect they are bit rotten as we bumped to 1.59 already.

Edit: added to commit description

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 1, 2016

Member

ut ACK. IIRC I back-ported these directly from boost master at the time, so dropping them in favor of a later fixed release makes sense.

Member

theuni commented Mar 1, 2016

ut ACK. IIRC I back-ported these directly from boost master at the time, so dropping them in favor of a later fixed release makes sense.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 1, 2016

Member

OH I was completely misreading the diff here, due to the surprising highlighting of a second-order diff.
You're just deleting the files not removing parts of it.
utACK fafe446

Member

laanwj commented Mar 1, 2016

OH I was completely misreading the diff here, due to the surprising highlighting of a second-order diff.
You're just deleting the files not removing parts of it.
utACK fafe446

@laanwj laanwj merged commit fafe446 into bitcoin:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 1, 2016

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1602-boost155 branch Mar 1, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 11, 2017

Merge #7616: [depends] Delete unused patches
fafe446 [depends] Delete unused patches (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment