/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix memleak in TorController [rework] #7637

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
P2P Resource usage
Projects
None yet
Milestone
No milestone
5 participants
@laanwj @jonasschnelli @theuni @MarcoFalke @paveljanik
@laanwj
Owner

laanwj commented Mar 3, 2016

It looks like, TorController::disconnected_cb(TorControlConnection& conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and deleting it only once in the destructor (thanks to Cory Fields for the idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.
@laanwj
Fix memleak in TorController [rework] 
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.
e219503

@laanwj laanwj referenced this pull request Mar 3, 2016

Closed

Fix memleak in TorController #7610

@laanwj laanwj added P2P Needs backport labels Mar 3, 2016

@jonasschnelli
Member

jonasschnelli commented Mar 3, 2016

utACK.

@laanwj laanwj added the Resource usage label Mar 3, 2016

@theuni
Member

theuni commented Mar 4, 2016

ut ACK

@laanwj laanwj merged commit e219503 into bitcoin:master Mar 11, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 11, 2016

@laanwj
Merge #7637: Fix memleak in TorController [rework] 
e219503 Fix memleak in TorController [rework] (Wladimir J. van der Laan)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
3da5d1b
@paveljanik

paveljanik commented on src/torcontrol.cpp in e219503 Mar 11, 2016

This removal generated new warning:

torcontrol.cpp:365:24: warning: private field 'base' is not used [-Wunused-private-field]
    struct event_base* base;
                       ^
1 warning generated.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

@laanwj @MarcoFalke
Fix memleak in TorController [rework] 
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e219503
66d5408
@MarcoFalke
Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

@MarcoFalke MarcoFalke removed the Needs backport label Jun 9, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

@laanwj @zander
Fix memleak in TorController [rework] 
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e219503
e693780

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

@laanwj @thokon00
Fix memleak in TorController [rework] 
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e219503
da87b1c

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

@laanwj @sickpig
Fix memleak in TorController [rework] 
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e219503
This commit was signed with a verified signature.
@sickpig sickpig Andrea Suisani
GPG key ID: A9CA1D0EE3789741 Learn about signing commits
1a43fa5

@str4d str4d referenced this pull request in zcash/zcash Mar 24, 2017

Merged

Tor ephemeral hidden services #2177

zkbot added a commit to zcash/zcash that referenced this pull request Mar 26, 2017

@zkbot
Auto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira 
Tor ephemeral hidden services

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6503 (included to reduce merge conflicts)
- bitcoin/bitcoin#6639
- bitcoin/bitcoin#6643
- bitcoin/bitcoin#7090
- bitcoin/bitcoin#7035
- bitcoin/bitcoin#7170
- bitcoin/bitcoin#7218 (non-QT part)
- bitcoin/bitcoin#7313
- bitcoin/bitcoin#7438
- bitcoin/bitcoin#7553
- bitcoin/bitcoin#7637
- bitcoin/bitcoin#7683
- bitcoin/bitcoin#7813
- bitcoin/bitcoin#7703
- bitcoin/bitcoin#8203
- bitcoin/bitcoin#9004
- bitcoin/bitcoin#9234
- bitcoin/bitcoin#9911 (partial)

Closes #2061.
45faa92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment