Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Avoid "Unknown command" messages when receiving getaddr on outbound c… #7642

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
6 participants
Contributor

rebroad commented Mar 4, 2016

…onnections.

Replaces #6344 and addresses concerns raised (i.e. now logs this exceptional event).

Owner

sipa commented Mar 5, 2016

utACK

Tiny nit: can you use a less wide commit title? See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for example.

@dgenr8 dgenr8 referenced this pull request in bitcoinclassic/bitcoinclassic Mar 5, 2016

Closed

Avoid "Unknown command" messages when receiving getaddr on outbound c… #129

Member

MarcoFalke commented Mar 7, 2016

utACK d84ea1a

Contributor

kirkalx commented Mar 7, 2016

utACK.
Was looking at this code recently @rebroad and as I recall there were a few other similar situations there if you are looking for some more cleanups. Otherwise I'll put it on my TODO list :)

e.g.

    else if (strCommand == NetMsgType::HEADERS && !fImporting && !fReindex) // Ignore headers received while importing
Contributor

rebroad commented Mar 8, 2016

@sipa commit reworded

@sipa sipa merged commit 9988554 into bitcoin:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Mar 9, 2016

Merge #7642: Avoid "Unknown command" messages when receiving getaddr …
…on outbound c…


9988554 No "Unknown command" for getaddr command. (R E Broadley)
Member

MarcoFalke commented Mar 14, 2016

Could be tagged with "Needs backport"

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment