New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockunspent help message #7646

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Projects
None yet
5 participants
@promag
Member

promag commented Mar 4, 2016

Current implementation allows the second parameter to be optional. In that case, and if unlock is true, all locked coins are unlocked.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 5, 2016

Member

utACK

Member

sipa commented Mar 5, 2016

utACK

@jonasschnelli jonasschnelli added the Wallet label Mar 6, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 6, 2016

Member

utACK

Member

jonasschnelli commented Mar 6, 2016

utACK

@promag promag changed the title from Fix lockunspents help message to Fix lockunspent help message Mar 6, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 6, 2016

Member

utACK cf23442

Member

MarcoFalke commented Mar 6, 2016

utACK cf23442

@laanwj

View changes

Show outdated Hide outdated src/wallet/rpcwallet.cpp
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 23, 2016

Member

Can you change this to just modify the help message, as the title implies?

Member

laanwj commented Mar 23, 2016

Can you change this to just modify the help message, as the title implies?

@promag

This comment has been minimized.

Show comment
Hide comment
@promag

promag Mar 23, 2016

Member

@laanwj fixed and rebased.

Member

promag commented Mar 23, 2016

@laanwj fixed and rebased.

@laanwj laanwj merged commit df9e923 into bitcoin:master Mar 23, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Mar 23, 2016

Merge #7646: Fix lockunspent help message
df9e923 Fix lockunspents help message (João Barbosa)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#7646: Fix lockunspent help message
df9e923 Fix lockunspents help message (João Barbosa)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#7646: Fix lockunspent help message
df9e923 Fix lockunspents help message (João Barbosa)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge bitcoin#7646: Fix lockunspent help message
df9e923 Fix lockunspents help message (João Barbosa)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge bitcoin#7646: Fix lockunspent help message
df9e923 Fix lockunspents help message (João Barbosa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment