Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add curl to Gitian setup instructions #7658
Conversation
|
ACK |
MarcoFalke
referenced this pull request
Mar 9, 2016
Closed
gitian: Add suport for deterministic armhf builds #7659
|
The gitian descriptors should be installing this now, although I suppose this saves time. |
|
As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97 So this pull seems like a good place to revert #7614? |
|
They're only needed on the guest system. |
jonasschnelli
added
the
Build system
label
Mar 9, 2016
Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system. Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories |
|
Without this patch, |
|
@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list. |
laanwj
changed the title from
Add curl to Gitian setup instrustions
to
Add curl to Gitian setup instructions
Mar 11, 2016
laanwj
added
the
Needs backport
label
Mar 14, 2016
laanwj
merged commit ce41cf0
into
bitcoin:master
Mar 14, 2016
added a commit
that referenced
this pull request
Mar 14, 2016
btcdrak
deleted the
btcdrak:curl
branch
Mar 14, 2016
added a commit
to MarcoFalke/bitcoin
that referenced
this pull request
Apr 27, 2016
|
Backported as part of #7938. Removing label 'Needs backport'. |
btcdrak commentedMar 9, 2016
curl is required to fetch dependencies
requires backport to all branches
[ci skip]