New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to Gitian setup instructions #7658

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Projects
None yet
5 participants
@btcdrak
Member

btcdrak commented Mar 9, 2016

curl is required to fetch dependencies

requires backport to all branches

[ci skip]

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

[ci skip]
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 9, 2016

Member

ACK

Member

MarcoFalke commented Mar 9, 2016

ACK

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 9, 2016

Member

The gitian descriptors should be installing this now, although I suppose this saves time.

Member

luke-jr commented Mar 9, 2016

The gitian descriptors should be installing this now, although I suppose this saves time.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 9, 2016

Member

As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97

So this pull seems like a good place to revert #7614?

Member

MarcoFalke commented Mar 9, 2016

As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97

So this pull seems like a good place to revert #7614?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 9, 2016

Member

They're only needed on the guest system.

Member

luke-jr commented Mar 9, 2016

They're only needed on the guest system.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 9, 2016

Member

They're only needed on the guest system.

Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system.

Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories

Member

MarcoFalke commented Mar 9, 2016

They're only needed on the guest system.

Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system.

Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Mar 9, 2016

Member

Without this patch, make -C depends/... command fails to download the dependencies required for gitian builds.

Member

btcdrak commented Mar 9, 2016

Without this patch, make -C depends/... command fails to download the dependencies required for gitian builds.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 9, 2016

Member

@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list.

Member

luke-jr commented Mar 9, 2016

@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list.

@laanwj laanwj changed the title from Add curl to Gitian setup instrustions to Add curl to Gitian setup instructions Mar 11, 2016

@laanwj laanwj merged commit ce41cf0 into bitcoin:master Mar 14, 2016

laanwj added a commit that referenced this pull request Mar 14, 2016

Merge #7658: Add curl to Gitian setup instructions
ce41cf0 Add curl to Gitian setup instrustions (BtcDrak)

@btcdrak btcdrak deleted the btcdrak:curl branch Mar 14, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 27, 2016

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

Github-Pull: #7658
Rebased-From: ce41cf0
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 9, 2016

Member

Backported as part of #7938. Removing label 'Needs backport'.

Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

Github-Pull: #7658
Rebased-From: ce41cf0

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

Github-Pull: #7658
Rebased-From: ce41cf0

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

Github-Pull: #7658
Rebased-From: ce41cf0

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

Add curl to Gitian setup instrustions
curl is required to fetch dependencies

Github-Pull: #7658
Rebased-From: ce41cf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment