New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the generate RPC call function for non-regtest #7663

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Projects
None yet
3 participants
@sipa
Member

sipa commented Mar 9, 2016

This complements #7507, allowing external scripts to take over the function of the internal setgenerate miner.

@sipa sipa referenced this pull request Mar 9, 2016

Merged

Remove internal miner #7507

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 10, 2016

Member

utACK.
nit: should we not exclude mainnet from generate?

Member

jonasschnelli commented Mar 10, 2016

utACK.
nit: should we not exclude mainnet from generate?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 10, 2016

Member
Member

sipa commented Mar 10, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 10, 2016

Member

400, which on any CPU thread would take over a day.

This would require adjustment over time (moore's law),.. but fine for me, it's anyways a nitpick.

Member

jonasschnelli commented Mar 10, 2016

400, which on any CPU thread would take over a day.

This would require adjustment over time (moore's law),.. but fine for me, it's anyways a nitpick.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 10, 2016

Member
Member

sipa commented Mar 10, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 10, 2016

Member

+1 for the warning. I guess there will be some bitcoin-novice users that type in generate 1 into the GUI console window and wait until "they have mined a couple of bitcoin" and I don't want Issues like "generate 1 takes ages to generate bitcoins". :-)

Member

jonasschnelli commented Mar 10, 2016

+1 for the warning. I guess there will be some bitcoin-novice users that type in generate 1 into the GUI console window and wait until "they have mined a couple of bitcoin" and I don't want Issues like "generate 1 takes ages to generate bitcoins". :-)

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 10, 2016

Member
Member

sipa commented Mar 10, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 11, 2016

Member

Concept ACK

with however many blocks were found in that time.

But never more than the number of blocks given as first argument, I hope?

Member

laanwj commented Mar 11, 2016

Concept ACK

with however many blocks were found in that time.

But never more than the number of blocks given as first argument, I hope?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 11, 2016

Member
Member

sipa commented Mar 11, 2016

@laanwj laanwj merged commit 8a253b3 into bitcoin:master Mar 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 14, 2016

Merge #7663: Make the generate RPC call function for non-regtest
8a253b3 Make the generate RPC call function for non-regtest (Pieter Wuille)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 14, 2016

Member

We should probably mention this in the 0.13 release notes

Member

laanwj commented Mar 14, 2016

We should probably mention this in the 0.13 release notes

@laanwj laanwj referenced this pull request Mar 14, 2016

Closed

TODO for release notes 0.13.0 #7678

14 of 16 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7663: Make the generate RPC call function for non-regtest
8a253b3 Make the generate RPC call function for non-regtest (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7663: Make the generate RPC call function for non-regtest
8a253b3 Make the generate RPC call function for non-regtest (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7663: Make the generate RPC call function for non-regtest
8a253b3 Make the generate RPC call function for non-regtest (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7663: Make the generate RPC call function for non-regtest
8a253b3 Make the generate RPC call function for non-regtest (Pieter Wuille)

thephez added a commit to thephez/dash-docs that referenced this pull request Feb 22, 2018

thephez added a commit to dash-docs/dash-docs that referenced this pull request Feb 27, 2018

[Content] v12.3 RPC changes (#38)
* content - Mempool related RPC updates
 - Add getmempoolancestors, getmempooldescendants, and getmempoolentry
RPCs
 - Update Ref and Table

* content - Generate RPCs updated
 - Mark get/setgenerate as removed
 - Add generatetoaddress details
 - Update Ref and Table

* content - Debug RPC updated
 - Change delimiter to + instead of comma
 - Update Ref and Table

* content - GetInfo RPCs updated
 - getaddednodeinfo, getmemoryinfo, getnetworkinfo
 - Update Ref and Table

* content - Added PreciousBlock RPC
 - Update Ref and Table

* content - Added and update RPCs
 - Debug, estimatepriority, estimatesmartpriority, listunspent,
signmessagewithprivkey, validateaddress
 - Update Ref and Table

* Update GObject Getcurrentvotes with shortened outpoint output
 - Update example and Vote Info field
 - Ref #24

* content - Update generate RPC
 - Add iterations parameter
 - Ref dashpay/dash#1790 (and bitcoin/bitcoin#7663)

* content - Update rawtransaction and generate RPCs
 - CreateRawTransaction, GetRawTransaction, and FundRawTransaction minor
updates
 - Some minor generate RPC updates for removed commands

* content - Update RPCs
 - Update GetBlockChainInfo and GetBlockTemplate
 - Add ImportMulti
 - Some minor generate RPC updates for removed commands

* content - Update Dash RPCs
 - Update GetGovernanceInfo and MasternodeList

* content - Update Pruning related RPCs
 - Update PruneBlockchain, ImportPrunedFunds, and RemovePrunedFunds

* content - RPC table
 - Minor updates

* content - Add SetBIP69Enabled RPC

* build - Update Makefile check to allow numbers in summary name

* content - Add example of RPC with named parameter

thephez added a commit to thephez/dash-docs that referenced this pull request Jun 11, 2018

[Content] v12.3 RPC changes (#38)
* content - Mempool related RPC updates
 - Add getmempoolancestors, getmempooldescendants, and getmempoolentry
RPCs
 - Update Ref and Table

* content - Generate RPCs updated
 - Mark get/setgenerate as removed
 - Add generatetoaddress details
 - Update Ref and Table

* content - Debug RPC updated
 - Change delimiter to + instead of comma
 - Update Ref and Table

* content - GetInfo RPCs updated
 - getaddednodeinfo, getmemoryinfo, getnetworkinfo
 - Update Ref and Table

* content - Added PreciousBlock RPC
 - Update Ref and Table

* content - Added and update RPCs
 - Debug, estimatepriority, estimatesmartpriority, listunspent,
signmessagewithprivkey, validateaddress
 - Update Ref and Table

* Update GObject Getcurrentvotes with shortened outpoint output
 - Update example and Vote Info field
 - Ref #24

* content - Update generate RPC
 - Add iterations parameter
 - Ref dashpay/dash#1790 (and bitcoin/bitcoin#7663)

* content - Update rawtransaction and generate RPCs
 - CreateRawTransaction, GetRawTransaction, and FundRawTransaction minor
updates
 - Some minor generate RPC updates for removed commands

* content - Update RPCs
 - Update GetBlockChainInfo and GetBlockTemplate
 - Add ImportMulti
 - Some minor generate RPC updates for removed commands

* content - Update Dash RPCs
 - Update GetGovernanceInfo and MasternodeList

* content - Update Pruning related RPCs
 - Update PruneBlockchain, ImportPrunedFunds, and RemovePrunedFunds

* content - RPC table
 - Minor updates

* content - Add SetBIP69Enabled RPC

* build - Update Makefile check to allow numbers in summary name

* content - Add example of RPC with named parameter

thephez added a commit to thephez/dash-docs that referenced this pull request Jun 11, 2018

[Content] v12.3 RPC changes (#38)
* content - Mempool related RPC updates
 - Add getmempoolancestors, getmempooldescendants, and getmempoolentry
RPCs
 - Update Ref and Table

* content - Generate RPCs updated
 - Mark get/setgenerate as removed
 - Add generatetoaddress details
 - Update Ref and Table

* content - Debug RPC updated
 - Change delimiter to + instead of comma
 - Update Ref and Table

* content - GetInfo RPCs updated
 - getaddednodeinfo, getmemoryinfo, getnetworkinfo
 - Update Ref and Table

* content - Added PreciousBlock RPC
 - Update Ref and Table

* content - Added and update RPCs
 - Debug, estimatepriority, estimatesmartpriority, listunspent,
signmessagewithprivkey, validateaddress
 - Update Ref and Table

* Update GObject Getcurrentvotes with shortened outpoint output
 - Update example and Vote Info field
 - Ref #24

* content - Update generate RPC
 - Add iterations parameter
 - Ref dashpay/dash#1790 (and bitcoin/bitcoin#7663)

* content - Update rawtransaction and generate RPCs
 - CreateRawTransaction, GetRawTransaction, and FundRawTransaction minor
updates
 - Some minor generate RPC updates for removed commands

* content - Update RPCs
 - Update GetBlockChainInfo and GetBlockTemplate
 - Add ImportMulti
 - Some minor generate RPC updates for removed commands

* content - Update Dash RPCs
 - Update GetGovernanceInfo and MasternodeList

* content - Update Pruning related RPCs
 - Update PruneBlockchain, ImportPrunedFunds, and RemovePrunedFunds

* content - RPC table
 - Minor updates

* content - Add SetBIP69Enabled RPC

* build - Update Makefile check to allow numbers in summary name

* content - Add example of RPC with named parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment