New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GetTempPath() to testutil #7667

Merged
merged 2 commits into from Mar 14, 2016

Conversation

Projects
None yet
5 participants
@musalbas
Contributor

musalbas commented Mar 11, 2016

Addresses #6702 and #6701.

This pull request creates a new source file for test utils, and moves GetTempPath() from util to testutil.

This is because per the above issues, GetTempPath() is insecure and has unchecked error conditions, making it unsuitable for use in production code. GetTempPath() is only used in the unit tests and not used anywhere in the main code, so it would be a good idea to move this to the test suite so that no one tries to use this in the future and it's not mixed with production code.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 11, 2016

Member

Nice!
utACK.

Member

jonasschnelli commented Mar 11, 2016

Nice!
utACK.

@jonasschnelli jonasschnelli added the Tests label Mar 11, 2016

@musalbas

This comment has been minimized.

Show comment
Hide comment
@musalbas

musalbas Mar 11, 2016

Contributor

Fixed Windows build error. The build passes now.

Contributor

musalbas commented Mar 11, 2016

Fixed Windows build error. The build passes now.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 11, 2016

Contributor

ACK

Contributor

paveljanik commented Mar 11, 2016

ACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 11, 2016

utACK 2fdaa25

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 14, 2016

Member

Yes, makes sense, utACK 2fdaa25

Member

laanwj commented Mar 14, 2016

Yes, makes sense, utACK 2fdaa25

@laanwj laanwj merged commit 2fdaa25 into bitcoin:master Mar 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 14, 2016

Merge #7667: Move GetTempPath() to testutil
2fdaa25 Move GetTempPath() to testutil. (Mustafa)
393b22e Add a source file for unit test utils. (Mustafa)

@fanquake fanquake referenced this pull request Jun 22, 2016

Closed

GetTempPath is insecure #6701

@dagurval dagurval referenced this pull request Apr 23, 2017

Merged

Util ports #197

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7667: Move GetTempPath() to testutil
2fdaa25 Move GetTempPath() to testutil. (Mustafa)
393b22e Add a source file for unit test utils. (Mustafa)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7667: Move GetTempPath() to testutil
2fdaa25 Move GetTempPath() to testutil. (Mustafa)
393b22e Add a source file for unit test utils. (Mustafa)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7667: Move GetTempPath() to testutil
2fdaa25 Move GetTempPath() to testutil. (Mustafa)
393b22e Add a source file for unit test utils. (Mustafa)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7667: Move GetTempPath() to testutil
2fdaa25 Move GetTempPath() to testutil. (Mustafa)
393b22e Add a source file for unit test utils. (Mustafa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment