New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history deletion bug after font size change #7668

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Projects
None yet
3 participants
@achow101
Member

achow101 commented Mar 11, 2016

This fixes a bug where the history was cleared when the font size was changed. The history is now kept unless explicitly cleared with the clear button.

Fix history deletion bug after font change
The history is no longer cleared after the font size is changed
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 11, 2016

Contributor

3 changed lines, 3 new lines added (could be two if if's opening { is on the same line ;-).

Nice and elegant!

Tested ACK. History is not deleted after font size changed in the UI.

Contributor

paveljanik commented Mar 11, 2016

3 changed lines, 3 new lines added (could be two if if's opening { is on the same line ;-).

Nice and elegant!

Tested ACK. History is not deleted after font size changed in the UI.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 11, 2016

Member

Hmm... when I had implemented this, I encountered that the font size change only works after clearing the console (because of some html subsystem). The console content should be restored at L494.

Are you sure the console window gets cleared when changing the font size? If so, what platform?

Member

jonasschnelli commented Mar 11, 2016

Hmm... when I had implemented this, I encountered that the font size change only works after clearing the console (because of some html subsystem). The console content should be restored at L494.

Are you sure the console window gets cleared when changing the font size? If so, what platform?

@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101

achow101 Mar 11, 2016

Member

@jonasschnelli It isn't the console, but rather the history in the text box for commands. When you hit the up arrow you can choose a previously entered command but after changing the font size that history is cleared. This fixes that

Member

achow101 commented Mar 11, 2016

@jonasschnelli It isn't the console, but rather the history in the text box for commands. When you hit the up arrow you can choose a previously entered command but after changing the font size that history is cleared. This fixes that

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 11, 2016

Member

Ah! Right.
Nice catch!

utACK.

Member

jonasschnelli commented Mar 11, 2016

Ah! Right.
Nice catch!

utACK.

@jonasschnelli jonasschnelli added the GUI label Mar 11, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 14, 2016

Member

Tested ACK 21e45a0

Member

jonasschnelli commented Mar 14, 2016

Tested ACK 21e45a0

@jonasschnelli jonasschnelli merged commit 21e45a0 into bitcoin:master Mar 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Mar 14, 2016

Merge #7668: Fix history deletion bug after font size change
21e45a0 Fix history deletion bug after font change (Andrew C)

@achow101 achow101 deleted the achow101:rpcconsole-hist-fix branch Oct 29, 2016

kyuupichan referenced this pull request in kyuupichan/BitcoinUnlimited Mar 12, 2017

Merge #7668: Fix history deletion bug after font size change
21e45a0 Fix history deletion bug after font change (Andrew C)

cddjr referenced this pull request in cddjr/BitcoinUnlimited Apr 6, 2017

Merge #7668: Fix history deletion bug after font size change
21e45a0 Fix history deletion bug after font change (Andrew C)

codablock added a commit to codablock/dash that referenced this pull request Sep 5, 2017

Merge #7668: Fix history deletion bug after font size change
21e45a0 Fix history deletion bug after font change (Andrew C)

codablock added a commit to codablock/dash that referenced this pull request Sep 5, 2017

Merge #7668: Fix history deletion bug after font size change
21e45a0 Fix history deletion bug after font change (Andrew C)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 7, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 1 (#1614)
* Merge pull request #7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request #7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request #7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request #7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request #7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request #7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge #7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge #7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge #7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment