New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Extend tests #7684

Merged
merged 4 commits into from Mar 16, 2016

Conversation

Projects
None yet
2 participants
@MarcoFalke
Member

MarcoFalke commented Mar 14, 2016

Please review commit-by-commit:

  • Parsing negative amounts must fail
  • No need to set up a network in wallet.py
  • Reuse a function (move-only)
  • Use constants (refactor-only)

@laanwj laanwj added the Tests label Mar 15, 2016

@laanwj laanwj merged commit fad8cfb into bitcoin:master Mar 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 16, 2016

Merge #7684: [qa] Extend tests
fad8cfb [qa] mininode: Add and use CONSTs (MarcoFalke)
fa8cd46 [qa] Move create_tx() to util.py (MarcoFalke)
fad7dc8 [qa] wallet: speed up tests (MarcoFalke)
fa3a81a [tests] Extend util_ParseMoney test case (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1603-qaCleanup1 branch Mar 17, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 5, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

[qa] Extend tests
Github-Pull: bitcoin#7684
Rebased-From: fa3a81a fad7dc8 fad8cfb

Conflicts:
	qa/rpc-tests/maxuploadtarget.py

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

[qa] Extend tests
nomnombtc: minus the changes to maxuploadtarget.py

Github-Pull: bitcoin#7684
Rebased-From: fa3a81a fad7dc8 fad8cfb

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

[qa] Extend tests
nomnombtc: minus the changes to maxuploadtarget.py

Github-Pull: bitcoin#7684
Rebased-From: fa3a81a fad7dc8 fad8cfb

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

[qa] Extend tests
nomnombtc: minus the changes to maxuploadtarget.py

Github-Pull: bitcoin#7684
Rebased-From: fa3a81a fad7dc8 fad8cfb

@dagurval dagurval referenced this pull request Jan 17, 2018

Merged

[qa] Extend tests #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment