New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Remove 0-fee from send dialog #7686

Merged
merged 2 commits into from Mar 17, 2016

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Mar 14, 2016

This pull makes -sendfreetransactions a debug feature and removes it from the GUI. Nonetheless, it is still possible to set sendfreetransactions=$bool for the GUI via command line or config arg.

@jonasschnelli jonasschnelli added the GUI label Mar 14, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 15, 2016

Member

The previous proposal was to move this to the coin control window. But I'm fine with this too, as it's still settable on the command line.
utACK

Member

laanwj commented Mar 15, 2016

The previous proposal was to move this to the coin control window. But I'm fine with this too, as it's still settable on the command line.
utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 15, 2016

Member

Agree with removing it because I don't think its useful to have it in the GUI. Will test...

Member

jonasschnelli commented Mar 15, 2016

Agree with removing it because I don't think its useful to have it in the GUI. Will test...

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 15, 2016

Member

It serves no purpose on mainnet, so there is no point in having it prominently in the GUI and confuse users.

Member

MarcoFalke commented Mar 15, 2016

It serves no purpose on mainnet, so there is no point in having it prominently in the GUI and confuse users.

@@ -617,7 +617,7 @@
<x>0</x>
<y>0</y>
<width>830</width>
<height>68</height>
<height>104</height>

This comment has been minimized.

@jonasschnelli

jonasschnelli Mar 15, 2016

Member

What's the reason for 104px height here? Is it because we have more space now for the scroll area? Currently, this gives some whitespace below the recipient-section-devider (bordered line).

@jonasschnelli

jonasschnelli Mar 15, 2016

Member

What's the reason for 104px height here? Is it because we have more space now for the scroll area? Currently, this gives some whitespace below the recipient-section-devider (bordered line).

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 15, 2016

Member

tested ACK fa48bb3

I'm happy to get rid of this checkbox which was setting a global state (fSendFreeTransactions) that also affects the RPC/Console interface.
Zero fee transactions could be reenabled over CoinControl, thought, allowing it only over RPC/Console is probably better.

Member

jonasschnelli commented Mar 15, 2016

tested ACK fa48bb3

I'm happy to get rid of this checkbox which was setting a global state (fSendFreeTransactions) that also affects the RPC/Console interface.
Zero fee transactions could be reenabled over CoinControl, thought, allowing it only over RPC/Console is probably better.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 15, 2016

Contributor

ACK fa48bb3

Contributor

paveljanik commented Mar 15, 2016

ACK fa48bb3

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon Mar 16, 2016

Member

concept ACK

Member

jtimon commented Mar 16, 2016

concept ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 17, 2016

Member

This leaves one instance of fSendFreeTransactions in src/qt/sendcoinsdialog.cpp

    if (!settings.contains("fSendFreeTransactions"))
        settings.setValue("fSendFreeTransactions", false);
Member

laanwj commented Mar 17, 2016

This leaves one instance of fSendFreeTransactions in src/qt/sendcoinsdialog.cpp

    if (!settings.contains("fSendFreeTransactions"))
        settings.setValue("fSendFreeTransactions", false);
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 17, 2016

Member

@laanwj Good catch. Removed the dead code.

Member

MarcoFalke commented Mar 17, 2016

@laanwj Good catch. Removed the dead code.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 17, 2016

Member

utACK fa48bb3

Member

laanwj commented Mar 17, 2016

utACK fa48bb3

@laanwj laanwj merged commit fae8467 into bitcoin:master Mar 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 17, 2016

Merge #7686: [qt] Remove 0-fee from send dialog
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1603-qt-0-fee branch Mar 17, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7686: [qt] Remove 0-fee from send dialog
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7686: [qt] Remove 0-fee from send dialog
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7686: [qt] Remove 0-fee from send dialog
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7686: [qt] Remove 0-fee from send dialog
fae8467 [qt] Remove unneeded "fSendFreeTransactions" check (MarcoFalke)
fa48bb3 [qt] Remove 0-fee from send dialog (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment