New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: make prioritise_transaction.py more robust #7697

Merged
merged 1 commit into from Mar 16, 2016

Conversation

Projects
None yet
3 participants
@sdaftuar
Member

sdaftuar commented Mar 16, 2016

Fixes the issue mentioned here: #7622 (comment)

This test was too sensitive to how many transactions might get selected; this change makes it more robust, and if there's a failure due to future changes, the test is now somewhat better structured and commented to make fixing easier.

@MarcoFalke

View changes

Show outdated Hide outdated qa/rpc-tests/prioritise_transaction.py
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 16, 2016

Member

Concept ACK 80ab22d

Member

MarcoFalke commented Mar 16, 2016

Concept ACK 80ab22d

@laanwj laanwj added the Tests label Mar 16, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 16, 2016

Member

Nice!
utACK 80ab22d

Member

laanwj commented Mar 16, 2016

Nice!
utACK 80ab22d

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Mar 16, 2016

Member

Updated to address @MarcoFalke's nit

Member

sdaftuar commented Mar 16, 2016

Updated to address @MarcoFalke's nit

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 16, 2016

Member

@sdaftuar Needs rebase

Member

MarcoFalke commented Mar 16, 2016

@sdaftuar Needs rebase

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Mar 16, 2016

Member

Thanks, rebased.

Member

sdaftuar commented Mar 16, 2016

Thanks, rebased.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 16, 2016

utACK ec14339

@laanwj laanwj merged commit ec14339 into bitcoin:master Mar 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 16, 2016

Merge #7697: Tests: make prioritise_transaction.py more robust
ec14339 Tests: make prioritise_transaction.py more robust (Suhas Daftuar)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 10, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment