New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock #7702

Merged
merged 1 commit into from Mar 18, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented Mar 17, 2016

No description provided.

@@ -38,7 +38,6 @@ def run_test(self):
self.nodes[0].settxfee(0) # return to automatic fee selection
txFS = self.nodes[0].signrawtransaction(txF['hex'])
txid = self.nodes[0].sendrawtransaction(txFS['hex'])
self.nodes[0].lockunspent(True, [us0])

This comment has been minimized.

@MarcoFalke

MarcoFalke Mar 17, 2016

Member

@jonasschnelli I fail to see why you added this noop. I guess you used it for debugging and it is save to remove.

@MarcoFalke

MarcoFalke Mar 17, 2016

Member

@jonasschnelli I fail to see why you added this noop. I guess you used it for debugging and it is save to remove.

This comment has been minimized.

@jonasschnelli

jonasschnelli Mar 17, 2016

Member

Yes. I guess this can be removed. Should be locked by L39 anyways.

@jonasschnelli

jonasschnelli Mar 17, 2016

Member

Yes. I guess this can be removed. Should be locked by L39 anyways.

This comment has been minimized.

@MarcoFalke

MarcoFalke Mar 17, 2016

Member

lockunspent(True) will _un_lock, but signrawtransaction does not add any lock.

@MarcoFalke

MarcoFalke Mar 17, 2016

Member

lockunspent(True) will _un_lock, but signrawtransaction does not add any lock.

@laanwj laanwj added the Tests label Mar 17, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj
Member

laanwj commented Mar 18, 2016

ACK fa4a522

@laanwj laanwj merged commit fa4a522 into bitcoin:master Mar 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 18, 2016

Merge #7702: [qa] Add tests verifychain, lockunspent, getbalance, lis…
…tsinceblock

fa4a522 [qa] Add tests verifychain, lockunspent, getbalance, listsinceblock (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1603-qaCleanup2 branch Mar 18, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 5, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment