/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock #7702

Merged
merged 1 commit into from Mar 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
3 participants
@MarcoFalke @laanwj @jonasschnelli
@MarcoFalke
Member

MarcoFalke commented Mar 17, 2016

No description provided.

@MarcoFalke MarcoFalke commented on the diff Mar 17, 2016

View full changes
qa/rpc-tests/mempool_limit.py
@@ -38,7 +38,6 @@ def run_test(self):
self.nodes[0].settxfee(0) # return to automatic fee selection
txFS = self.nodes[0].signrawtransaction(txF['hex'])
txid = self.nodes[0].sendrawtransaction(txFS['hex'])
- self.nodes[0].lockunspent(True, [us0])
@MarcoFalke

MarcoFalke Mar 17, 2016

Member

@jonasschnelli I fail to see why you added this noop. I guess you used it for debugging and it is save to remove.

@jonasschnelli

jonasschnelli Mar 17, 2016

Member

Yes. I guess this can be removed. Should be locked by L39 anyways.

@MarcoFalke

MarcoFalke Mar 17, 2016

Member

lockunspent(True) will _un_lock, but signrawtransaction does not add any lock.

@laanwj laanwj added the Tests label Mar 17, 2016

@laanwj
Owner

laanwj commented Mar 18, 2016

ACK fa4a522

@laanwj laanwj merged commit fa4a522 into bitcoin:master Mar 18, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 18, 2016

@laanwj
Merge #7702: [qa] Add tests verifychain, lockunspent, getbalance, lis… 
…tsinceblock


fa4a522 [qa] Add tests verifychain, lockunspent, getbalance, listsinceblock (MarcoFalke)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
29e1131

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1603-qaCleanup2 branch Mar 18, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 5, 2016

@MarcoFalke
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
f23cb7c

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

@MarcoFalke @zander
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
6520310

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

@MarcoFalke @nomnombtc
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
d0bdd79

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@MarcoFalke @nomnombtc
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
f817e4c

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@MarcoFalke @nomnombtc
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
94ffa55

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

@MarcoFalke @sickpig
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock 
Github-Pull: #7702
Rebased-From: fa4a522
This commit was signed with a verified signature.
@sickpig sickpig Andrea Suisani
GPG key ID: A9CA1D0EE3789741 Learn about signing commits
5500a48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment