New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-aux] Update Boost & check macros to latest serials #7711

Merged
merged 1 commit into from Apr 2, 2016

Conversation

Projects
None yet
5 participants
@fanquake
Member

fanquake commented Mar 18, 2016

No description provided.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 18, 2016

Member

LGTM.
ping @theuni

Member

jonasschnelli commented Mar 18, 2016

LGTM.
ping @theuni

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Mar 18, 2016

Member

@fanquake: Looks like this drops our libsubdirs boost patch (which I thought made it upstream). Was that intentional?

Member

theuni commented Mar 18, 2016

@fanquake: Looks like this drops our libsubdirs boost patch (which I thought made it upstream). Was that intentional?

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Mar 19, 2016

Member

@theuni no, my mistake. The only patch of yours I can see being merged into Boost base was in serial 22.

This patch hasn't yet made it upstream.

    dnl some arches may advertise a cpu type that doesn't line up with their
    dnl prefix's cpu type. For example, uname may report armv7l while libs are
    dnl installed to /usr/lib/arm-linux-gnueabihf. Try getting the compiler's
    dnl value for an extra chance of finding the correct path.
    libsubdirs="lib/`$CXX -dumpmachine 2>/dev/null` $libsubdirs"
Member

fanquake commented Mar 19, 2016

@theuni no, my mistake. The only patch of yours I can see being merged into Boost base was in serial 22.

This patch hasn't yet made it upstream.

    dnl some arches may advertise a cpu type that doesn't line up with their
    dnl prefix's cpu type. For example, uname may report armv7l while libs are
    dnl installed to /usr/lib/arm-linux-gnueabihf. Try getting the compiler's
    dnl value for an extra chance of finding the correct path.
    libsubdirs="lib/`$CXX -dumpmachine 2>/dev/null` $libsubdirs"
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 23, 2016

Member

Is this ready for merge? (e.g. all patches are included now?)

Member

laanwj commented Mar 23, 2016

Is this ready for merge? (e.g. all patches are included now?)

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 31, 2016

Contributor

Fixes #5516.

configure output differences here (OS X: master->#7711):

Expected:

-checking if compiler needs -Werror to reject unknown flags... yes
-checking whether pthreads work with -pthread... yes
+checking whether gcc is Clang... yes
+checking whether Clang needs flag to prevent "argument unused" warning when linking with -pthread... -Qunused-arguments

Unexpected:

-checking for __attribute__((visibility))... yes
+checking for __attribute__((visibility))... no

ACK cf5c786

Contributor

paveljanik commented Mar 31, 2016

Fixes #5516.

configure output differences here (OS X: master->#7711):

Expected:

-checking if compiler needs -Werror to reject unknown flags... yes
-checking whether pthreads work with -pthread... yes
+checking whether gcc is Clang... yes
+checking whether Clang needs flag to prevent "argument unused" warning when linking with -pthread... -Qunused-arguments

Unexpected:

-checking for __attribute__((visibility))... yes
+checking for __attribute__((visibility))... no

ACK cf5c786

@laanwj laanwj merged commit cf5c786 into bitcoin:master Apr 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 2, 2016

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)
@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Apr 2, 2016

Member

Mm, I missed this before merge.

@paveljanik to clarify, are you saying that after this change, the visibility attribute isn't found? If so, that'll be quite ugly at link time. I would think it would cause a flood of "visibility doesn't match" warnings.

Member

theuni commented Apr 2, 2016

Mm, I missed this before merge.

@paveljanik to clarify, are you saying that after this change, the visibility attribute isn't found? If so, that'll be quite ugly at link time. I would think it would cause a flood of "visibility doesn't match" warnings.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 2, 2016

Contributor

No such warnings here...

Contributor

paveljanik commented Apr 2, 2016

No such warnings here...

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 2, 2016

Contributor

config.log here:

configure:20859: checking for __attribute__((visibility))
configure:20883: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -isystem /opt/local/include -I/opt/local/include/db48 -DMAC_OSX  -Wl,-headerpad_max_install_names conftest.cpp  -L/opt/local/lib -L/opt/local/lib/db48 >&5
conftest.cpp:30:56: warning: target does not support 'protected' visibility; using 'default' [-Wunsupported-visibility]
                    int foo_pro( void ) __attribute__((visibility("protected")));
                                                       ^
1 warning generated.
configure:20883: $? = 0
configure:20896: result: no
Contributor

paveljanik commented Apr 2, 2016

config.log here:

configure:20859: checking for __attribute__((visibility))
configure:20883: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -isystem /opt/local/include -I/opt/local/include/db48 -DMAC_OSX  -Wl,-headerpad_max_install_names conftest.cpp  -L/opt/local/lib -L/opt/local/lib/db48 >&5
conftest.cpp:30:56: warning: target does not support 'protected' visibility; using 'default' [-Wunsupported-visibility]
                    int foo_pro( void ) __attribute__((visibility("protected")));
                                                       ^
1 warning generated.
configure:20883: $? = 0
configure:20896: result: no
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 2, 2016

Member

Must be due to this change:

                [visibility], [
                     int foo_def( void ) __attribute__(($1("default")));
                     int foo_hid( void ) __attribute__(($1("hidden")));
+                    int foo_int( void ) __attribute__(($1("internal")));
+                    int foo_pro( void ) __attribute__(($1("protected")));
                 ],

Apparently it needs all kinds of visibility to be supported for that check.

Still fine on ubuntu 14.04:

configure:20274: checking for __attribute__((visibility))
configure:20298: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS  conftest.cpp  >&5
configure:20298: $? = 0
configure:20311: result: yes

That's kind of annoying as we don't use 'protected' visibility at all, as far as I know.

Member

laanwj commented Apr 2, 2016

Must be due to this change:

                [visibility], [
                     int foo_def( void ) __attribute__(($1("default")));
                     int foo_hid( void ) __attribute__(($1("hidden")));
+                    int foo_int( void ) __attribute__(($1("internal")));
+                    int foo_pro( void ) __attribute__(($1("protected")));
                 ],

Apparently it needs all kinds of visibility to be supported for that check.

Still fine on ubuntu 14.04:

configure:20274: checking for __attribute__((visibility))
configure:20298: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS  conftest.cpp  >&5
configure:20298: $? = 0
configure:20311: result: yes

That's kind of annoying as we don't use 'protected' visibility at all, as far as I know.

@fanquake fanquake deleted the fanquake:build-aux-change branch May 12, 2016

@rebroad rebroad referenced this pull request Sep 21, 2016

Merged

C++11 with gitian support #164

@laanwj laanwj added this to the 0.12.2 milestone Sep 26, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)

@schinzelh schinzelh referenced this pull request Oct 23, 2017

Closed

[WIP] Update build system to Bitcoin 0.13.2 #1692

22 of 24 tasks complete

@str4d str4d referenced this pull request Oct 29, 2017

Merged

Darwin build fixes #2697

zkbot added a commit to zcash/zcash that referenced this pull request Nov 29, 2017

Auto merge of #2697 - str4d:darwin-build, r=<try>
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114

zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017

Auto merge of #2697 - str4d:darwin-build, r=<try>
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114

zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017

Auto merge of #2697 - str4d:darwin-build, r=str4d
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114

zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017

Auto merge of #2697 - str4d:darwin-build, r=str4d
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7711: [build-aux] Update Boost & check macros to latest serials
cf5c786 [build-aux] Update Boost & check macros to latest serials (fanquake)

@fanquake fanquake removed the Needs backport label Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment