New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] rpc-test: Normalize assert() #7720

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Mar 19, 2016

Refactoring to make the test easier to read and remove redundant code:

  • assert_equal( $boolean, True) can be written as assert( $boolean )
  • Remove usage of errorString et al., which is error prone when the string is not erased after usage. Also made some of them more verbose/strict.
@jmcorgan

This comment has been minimized.

Show comment
Hide comment
@jmcorgan

jmcorgan Mar 19, 2016

Contributor

utACK

Contributor

jmcorgan commented Mar 19, 2016

utACK

@jonasschnelli jonasschnelli added the Tests label Mar 19, 2016

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Mar 21, 2016

Contributor

utACK

Contributor

dcousens commented Mar 21, 2016

utACK

@laanwj laanwj merged commit fab3890 into bitcoin:master Mar 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 21, 2016

Merge #7720: [qa] rpc-test: Normalize assert()
fab3890 [qa] rpc-test: Normalize assert() (MarcoFalke)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 21, 2016

Member

utACK fab3890

Member

laanwj commented Mar 21, 2016

utACK fab3890

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1603-qaAssertNorm branch Mar 21, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 5, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment