Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[qa] rpc-test: Normalize assert() #7720
Conversation
|
utACK |
jonasschnelli
added
the
Tests
label
Mar 19, 2016
|
utACK |
laanwj
merged commit fab3890
into
bitcoin:master
Mar 21, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
that referenced
this pull request
Mar 21, 2016
|
utACK fab3890 |
MarcoFalke
deleted the
MarcoFalke:Mf1603-qaAssertNorm
branch
Mar 21, 2016
added a commit
to MarcoFalke/bitcoin
that referenced
this pull request
Apr 5, 2016
added a commit
to zander/bitcoinclassic
that referenced
this pull request
Jun 16, 2016
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Nov 11, 2016
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Nov 12, 2016
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Nov 12, 2016
added a commit
to nomnombtc/bitcoin
that referenced
this pull request
Nov 13, 2016
added a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MarcoFalke commentedMar 19, 2016
Refactoring to make the test easier to read and remove redundant code:
assert_equal( $boolean, True)can be written asassert( $boolean )errorStringet al., which is error prone when the string is not erased after usage. Also made some of them more verbose/strict.