New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Debug window: replace "Build date" with "Datadir" #7732

Merged
merged 2 commits into from Mar 25, 2016

Conversation

Projects
None yet
3 participants
@jonasschnelli
Member

jonasschnelli commented Mar 22, 2016

The build date does only make sense for custom/self-compiled bitcoin-core versions because we are using static build-dates for our deterministic release builds.

Having a quick option to get the current datadir is much more valuable for debug purposes.

I could optional re-add the build-date for self compiled versions if someone brings up a concrete reason/value to keep it.

Optional this could be extended to open the datadir in the OS file explore when someone clicks on the label (Would require some platform dependent code: http://stackoverflow.com/questions/3490336/how-to-reveal-in-finder-or-show-in-explorer-with-qt).

[Qt] Debug window: replace "Build date" with "Datadir"
The build date does only makes sense for custom/self-compiled bitcoin-core versions because we are using static build-dates for our deterministic release builds.
Having a quick option to get the current datadir is much more valuable for debug purposes.

@jonasschnelli jonasschnelli added the GUI label Mar 22, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 22, 2016

Member

Awesome, ACK 4856f1d

Optional this could be extended to open the datadir in the OS file explore when someone clicks on the label

This couldn't use the same functionality that we use to open the debug log?

OTOH we don't want to make it too easy to mess around in the data directory, certainly not while the application is running. Probably just showing it is good enough.

Member

laanwj commented Mar 22, 2016

Awesome, ACK 4856f1d

Optional this could be extended to open the datadir in the OS file explore when someone clicks on the label

This couldn't use the same functionality that we use to open the debug log?

OTOH we don't want to make it too easy to mess around in the data directory, certainly not while the application is running. Probably just showing it is good enough.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 24, 2016

Member

I could optional re-add the build-date for self compiled versions if someone brings up a concrete reason/value to keep it.

We already display the commit-hash, which identifies the code that was compiled.

ACK 4856f1d

Member

MarcoFalke commented Mar 24, 2016

I could optional re-add the build-date for self compiled versions if someone brings up a concrete reason/value to keep it.

We already display the commit-hash, which identifies the code that was compiled.

ACK 4856f1d

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 24, 2016

Member

We already display the commit-hash, which identifies the code that was compiled.

Yes, exactly, what is important is what was compiled, not when.

Member

laanwj commented Mar 24, 2016

We already display the commit-hash, which identifies the code that was compiled.

Yes, exactly, what is important is what was compiled, not when.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 24, 2016

Member

Nits:

  • formatBuildDate is unused after this, and can go

We can either do there here, or in a pull that completely removes CLIENT_DATE/BUILD_DATE, I don't mind.

Member

laanwj commented Mar 24, 2016

Nits:

  • formatBuildDate is unused after this, and can go

We can either do there here, or in a pull that completely removes CLIENT_DATE/BUILD_DATE, I don't mind.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 24, 2016

Member

Good catch. Should be at least another commit as it is unrelated to the GUI.

Member

MarcoFalke commented Mar 24, 2016

Good catch. Should be at least another commit as it is unrelated to the GUI.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 24, 2016

Member

Well, ClientModel::formatBuildDate is part of the GUI code, so could be removed here.

I indeed agree removing CLIENT_DATE/BUILD_DATE should be a separate pull, as it is unrelated to the GUI.

Member

laanwj commented Mar 24, 2016

Well, ClientModel::formatBuildDate is part of the GUI code, so could be removed here.

I indeed agree removing CLIENT_DATE/BUILD_DATE should be a separate pull, as it is unrelated to the GUI.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 24, 2016

Member

Right. I wasn't sure if we want to re-add the formatted build date somewhere.
Just added a commit that removes the now unused method.

Member

jonasschnelli commented Mar 24, 2016

Right. I wasn't sure if we want to re-add the formatted build date somewhere.
Just added a commit that removes the now unused method.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 25, 2016

Member

Had to re-trigger Travis due to an unrelated problem (#7463)

Member

laanwj commented Mar 25, 2016

Had to re-trigger Travis due to an unrelated problem (#7463)

@laanwj laanwj merged commit fc737d1 into bitcoin:master Mar 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 25, 2016

Merge #7732: [Qt] Debug window: replace "Build date" with "Datadir"
fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

laanwj added a commit to laanwj/bitcoin that referenced this pull request Mar 26, 2016

build: remove `BUILD_DATE` / `CLIENT_DATE`
Continues bitcoin#7732 on the core side.

This gets rid of a few ugly constructions, and build date is useless
anyhow in the (most common) case of gitian builds.

laanwj added a commit to laanwj/bitcoin that referenced this pull request Jun 9, 2016

build: Get rid of `CLIENT_DATE`
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.

Continues bitcoin#7732 which did this for the GUI.

kyuupichan referenced this pull request in kyuupichan/BitcoinUnlimited Mar 12, 2017

Merge #7732: [Qt] Debug window: replace "Build date" with "Datadir"
fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

cddjr referenced this pull request in cddjr/BitcoinUnlimited Apr 6, 2017

Merge #7732: [Qt] Debug window: replace "Build date" with "Datadir"
fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 7, 2017

Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Dat…
…adir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 (#1615)
* Merge bitcoin#7506: Use CCoinControl selection in CWallet::FundTransaction

d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa)

* Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Datadir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

* Merge bitcoin#7707: [RPC][QT] UI support for abandoned transactions

8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli)

* Merge bitcoin#7688: List solvability in listunspent output and improve help

c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)

* Merge bitcoin#8006: Qt: Add option to disable the system tray icon

8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)

* Merge bitcoin#8073: qt: askpassphrasedialog: Clear pass fields on accept

02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin)

* Merge bitcoin#8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

* Merge bitcoin#8257: Do not ask a UI question from bitcoind

1acf1db Do not ask a UI question from bitcoind (Pieter Wuille)

* Merge bitcoin#8463: [qt] Remove Priority from coincontrol dialog

fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)

* Merge bitcoin#8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee

0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)

* Merge bitcoin#8672: Qt: Show transaction size in transaction details window

c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
 \-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)

* Merge bitcoin#8371: [Qt] Add out-of-sync modal info layer

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge bitcoin#8805: Trivial: Grammar and capitalization

c9ce17b Trivial: Grammar and capitalization (Derek Miller)

* Merge bitcoin#8885: gui: fix ban from qt console

cb78c60 gui: fix ban from qt console (Cory Fields)

* Merge bitcoin#8821: [qt] sync-overlay: Don't block during reindex

fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke)
faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke)

* Support themes for new transaction_abandoned icon

* Fix constructor call to COutput

* Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo when no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

* Merge bitcoin#8918: Qt: Add "Copy URI" to payment request context menu

21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)

* Merge bitcoin#8925: qt: Display minimum ping in debug window.

1724a40 Display minimum ping in debug window. (R E Broadley)

* Merge bitcoin#8972: [Qt] make warnings label selectable (jonasschnelli)

ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli)

* Make background of warning icon transparent in modaloverlay

* Merge bitcoin#9088: Reduce ambiguity of warning message

77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)

* Replace Bitcoin with Dash in modal overlay

* Remove clicked signals from labelWalletStatus and labelTransactionsStatus

As both are really just labels, clicking on those is not possible.
This is different in Bitcoin, where these labels are actually buttons.

* Pull out modaloverlay show/hide into it's own if/else block and switch to time based check

Also don't use masternodeSync.IsBlockchainSynced() for now as it won't
report the blockchain being synced before the first block (or other MN
data?) arrives. This would otherwise give the impression that sync is
being stuck.

lateminer added a commit to lateminer/bitcoin that referenced this pull request Jan 5, 2018

build: Get rid of `CLIENT_DATE`
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.

Continues bitcoin#7732 which did this for the GUI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment