New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: make github-merge.py use py3 #7737

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
2 participants
@laanwj
Member

laanwj commented Mar 23, 2016

This makes github-merge.py the first developer tool to go all Python 3 (for context see #7717).

The changes are straightforward as the script already was from __future__ import division,print_function,unicode_literals.

However urllib2 changed name, and json will only accept unicode data not bytes.

This retains py2 compatibility for now: not strictly necessary as the script is not used by the build system (see #7723) - but it was easy.

devtools: make github-merge.py use py3
This makes github-merge.py the first developer tool to go
all Python 3 (for context see #7717).

The changes are straightforward as the script already was
`from __future__ import division,print_function,unicode_literals`.

However urllib2 changed name, and json will only accept unicode data not
bytes.

This retains py2 compatibility for now: not strictly necessary
as it's not used by the build system - but it was easy.
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 24, 2016

utACK f11c5a3

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 29, 2016

Member

I've been using this python3 version for about a week now, without problems.
so tested ACK on my own pull

Member

laanwj commented Mar 29, 2016

I've been using this python3 version for about a week now, without problems.
so tested ACK on my own pull

@laanwj laanwj merged commit f11c5a3 into bitcoin:master Mar 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 29, 2016

Merge #7737: devtools: make github-merge.py use py3
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7737: devtools: make github-merge.py use py3
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7737: devtools: make github-merge.py use py3
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7737: devtools: make github-merge.py use py3
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7737: devtools: make github-merge.py use py3
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment