New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_framework: python3.4 authproxy compat #7751

Merged
merged 2 commits into from Mar 28, 2016

Conversation

Projects
None yet
4 participants
@laanwj
Member

laanwj commented Mar 27, 2016

Changed in version 3.4: The strict parameter was removed. HTTP 0.9-style “Simple Responses” are not longer supported. (https://docs.python.org/3/library/http.client.html)

Work around this by using a named parameter.

Also avoid an infinite loop in encoding, by ensuring EncodeDecimal returns a string. round(Decimal) used to convert it to float, but it no longer does. Strings are supported since #6380, so just use that.

@MarcoFalke

View changes

Show outdated Hide outdated qa/rpc-tests/test_framework/authproxy.py

@laanwj laanwj referenced this pull request Mar 27, 2016

Closed

zmq: mempool notifications #7753

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 28, 2016

Member

@MarcoFalke Ok, split into two commits

Member

laanwj commented Mar 28, 2016

@MarcoFalke Ok, split into two commits

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Mar 28, 2016

Member

Tested ACK 28b1ec3

Member

MarcoFalke commented Mar 28, 2016

Tested ACK 28b1ec3

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 28, 2016

Member

utACK

Member

sipa commented Mar 28, 2016

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 28, 2016

Member

Travis fail was unrelated (#7470), retriggered.

Member

laanwj commented Mar 28, 2016

Travis fail was unrelated (#7470), retriggered.

laanwj and others added some commits Mar 28, 2016

test_framework: Avoid infinite loop in encoding Decimal
Avoid an infinite loop in encoding, by ensuring EncodeDecimal
returns a string. round(Decimal) used to convert it to
float, but it no longer does in python 3.x. Strings are
supported since #6380, so just use that.
test_framework: Py3.4 compat: Specify timeout parameter by name
Changed in version 3.4: The strict parameter was removed. HTTP 0.9-style
“Simple Responses” are not longer supported.
(https://docs.python.org/3/library/http.client.html)

Source: jgarzik/python-bitcoinrpc@7ebeebb
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 28, 2016

utACK e7e48ba

@laanwj laanwj merged commit e7e48ba into bitcoin:master Mar 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 28, 2016

Merge #7751: test_framework: python3.4 authproxy compat
e7e48ba test_framework: Py3.4 compat: Specify timeout parameter by name (Luke Dashjr)
d7b80b5 test_framework: Avoid infinite loop in encoding Decimal (Wladimir J. van der Laan)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 9, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@dagurval dagurval referenced this pull request Aug 29, 2017

Merged

Python 3 for qa #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment