New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] remove trailing output-index from transaction-id #7761

Merged
merged 1 commit into from Mar 30, 2016

Conversation

Projects
None yet
6 participants
@jonasschnelli
Member

jonasschnelli commented Mar 29, 2016

The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.

[Qt] remove trailing output-index from transaction-id
The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.

@jonasschnelli jonasschnelli added the GUI label Mar 29, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 29, 2016

Contributor

See #7499 and #2970.

Contributor

paveljanik commented Mar 29, 2016

See #7499 and #2970.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Mar 29, 2016

utACK 7d5e31a

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 29, 2016

Contributor

Before:
screen shot 2016-03-29 at 11 45 22

After:

screen shot 2016-03-29 at 11 45 56

ACK 7d5e31a

Contributor

paveljanik commented Mar 29, 2016

Before:
screen shot 2016-03-29 at 11 45 22

After:

screen shot 2016-03-29 at 11 45 56

ACK 7d5e31a

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 29, 2016

Contributor

Several people like the previous behaviour though... This also changes the "Copy transaction ID" - to copy the txid only (from txid-voutnr).

Contributor

paveljanik commented Mar 29, 2016

Several people like the previous behaviour though... This also changes the "Copy transaction ID" - to copy the txid only (from txid-voutnr).

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 29, 2016

Member

Concept ACK. I expect the people who rely on the old behaviour to be much fewer than those that get confused by it.

Member

sipa commented Mar 29, 2016

Concept ACK. I expect the people who rely on the old behaviour to be much fewer than those that get confused by it.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 29, 2016

Member

This also changes the "Copy transaction ID"

That's most of the point of this change. People paste that into block explorers and such, which don't know the format. Do you know of anyone (tools, applications and such) that adopted the txid-vout format besides us?

I mean theoretically I agree with you, the records represent a output not a transaction, and very strictly doing this is wrong. But it confuses so many people that I'm also convinced of this now.

Member

laanwj commented Mar 29, 2016

This also changes the "Copy transaction ID"

That's most of the point of this change. People paste that into block explorers and such, which don't know the format. Do you know of anyone (tools, applications and such) that adopted the txid-vout format besides us?

I mean theoretically I agree with you, the records represent a output not a transaction, and very strictly doing this is wrong. But it confuses so many people that I'm also convinced of this now.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 29, 2016

Contributor

I do not know anyone using it. And anyone using it can workaround it easily. Thus I already ACKed above.

Contributor

paveljanik commented Mar 29, 2016

I do not know anyone using it. And anyone using it can workaround it easily. Thus I already ACKed above.

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Mar 30, 2016

Contributor

utACK 7d5e31a

A txid + output # would be more properly called an "Outpoint ID" anyway.

Contributor

petertodd commented Mar 30, 2016

utACK 7d5e31a

A txid + output # would be more properly called an "Outpoint ID" anyway.

@laanwj laanwj merged commit 7d5e31a into bitcoin:master Mar 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 30, 2016

Merge #7761: [Qt] remove trailing output-index from transaction-id
7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#7761: [Qt] remove trailing output-index from transactio…
…n-id

7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#7761: [Qt] remove trailing output-index from transactio…
…n-id

7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge bitcoin#7761: [Qt] remove trailing output-index from transactio…
…n-id

7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge bitcoin#7761: [Qt] remove trailing output-index from transactio…
…n-id

7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment